After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757539 - Add a help overlay for shortcuts
Add a help overlay for shortcuts
Status: RESOLVED OBSOLETE
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on: 757888
Blocks:
 
 
Reported: 2015-11-03 18:42 UTC by Debarshi Ray
Modified: 2021-07-05 11:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add a help overlay for shortcuts (5.04 KB, patch)
2015-11-03 18:47 UTC, Debarshi Ray
none Details | Review
Screenshot (57.19 KB, image/png)
2015-11-03 18:48 UTC, Debarshi Ray
  Details
Add a help overlay for shortcuts (8.27 KB, patch)
2015-11-13 15:03 UTC, Debarshi Ray
none Details | Review
Added help overlay for shortcuts with the new GtkShortcutsWindow (6.17 KB, patch)
2015-11-13 17:38 UTC, Umang Jain
none Details | Review
Add a help overlay for shortcuts (9.26 KB, patch)
2015-11-16 14:46 UTC, Debarshi Ray
committed Details | Review
app-menu: Add "Keyboard Shortcuts" entry (868 bytes, patch)
2015-11-16 14:57 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2015-11-03 18:42:41 UTC
Let's add a help overlay for shortcuts to play with the new GtkShortcutsWindow in gtk+.
Comment 1 Debarshi Ray 2015-11-03 18:47:05 UTC
Created attachment 314763 [details] [review]
Add a help overlay for shortcuts
Comment 2 Debarshi Ray 2015-11-03 18:48:53 UTC
Created attachment 314764 [details]
Screenshot
Comment 3 Debarshi Ray 2015-11-10 14:35:07 UTC
The inability to specify different shortcuts for LTR and RTL is an issue. See bug 757888
Comment 4 Debarshi Ray 2015-11-13 15:03:29 UTC
Created attachment 315409 [details] [review]
Add a help overlay for shortcuts

I was sloppy and hadn't 'git add'ed all the hunks.
Comment 5 Umang Jain 2015-11-13 17:38:49 UTC
Created attachment 315422 [details] [review]
Added help overlay for shortcuts with the new GtkShortcutsWindow

https://bugzilla.gnome.org/show_bug.cgi?id=757909
Comment 6 Umang Jain 2015-11-13 17:49:59 UTC
Sorry, Please remove the Patch "Added help overlay for shortcuts with the new GtkShortcutsWindow" submitted by me. I accidentally had this link open and submitted the bug number for this. Sorry once again.
Comment 7 Cosimo Cecchi 2015-11-13 18:54:36 UTC
Review of attachment 315409 [details] [review]:

Looks good to me, thanks!
Comment 8 Debarshi Ray 2015-11-16 14:46:05 UTC
Created attachment 315680 [details] [review]
Add a help overlay for shortcuts

Resolve LTR vs RTL, and the help-overlay.ui to po/POTFILES.in
Comment 9 Debarshi Ray 2015-11-16 14:47:25 UTC
Comment on attachment 315680 [details] [review]
Add a help overlay for shortcuts

Pushed to master. Thanks, Cosimo.
Comment 10 Debarshi Ray 2015-11-16 14:51:31 UTC
Reopening.

We need to add a "Keyboard Shortcuts" entry to the app-menu [1], and check the gestures supported by EvView and add them.

[1] https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows
Comment 11 Debarshi Ray 2015-11-16 14:57:42 UTC
Created attachment 315681 [details] [review]
app-menu: Add "Keyboard Shortcuts" entry
Comment 12 Debarshi Ray 2015-11-25 16:20:18 UTC
Comment on attachment 315681 [details] [review]
app-menu: Add "Keyboard Shortcuts" entry

Pushed to master. The last remaining item is to add the gestures.
Comment 13 GNOME Infrastructure Team 2021-07-05 11:31:51 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/gnome-documents/-/issues/

Thank you for your understanding and your help.