After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756388 - qtmux: Add ProRes support
qtmux: Add ProRes support
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.6.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-11 11:16 UTC by Thibault Saunier
Modified: 2015-10-28 14:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtmux: Add prores support (1.96 KB, patch)
2015-10-11 11:16 UTC, Thibault Saunier 		none Details | Review
qtmux: Add prores support (1.93 KB, patch)
2015-10-12 18:55 UTC, Thibault Saunier 		committed Details | Review

Description Thibault Saunier 2015-10-11 11:16:04 UTC 
Everything is in the title
Comment 1 Thibault Saunier 2015-10-11 11:16:08 UTC 
Created attachment 313055 [details] [review]
qtmux: Add prores support
Comment 2 Sebastian Dröge (slomo) 2015-10-12 13:50:19 UTC 
Review of attachment 313055 [details] [review]:

::: gst/isomp4/gstqtmux.c
@@ +4028,3 @@
+    const gchar *variant;
+
+    variant = gst_structure_get_string (structure, "format");

Here you allow various formats ...

::: gst/isomp4/gstqtmuxmap.c
@@ +75,3 @@
 
+#define PRORES_CAPS \
+  "video/x-prores, variant = (string) standard," \

... here only standard.
Comment 3 Thibault Saunier 2015-10-12 18:55:07 UTC 
Created attachment 313137 [details] [review]
qtmux: Add prores support
Comment 4 Sebastian Dröge (slomo) 2015-10-13 08:02:41 UTC 
Comment on attachment 313137 [details] [review]
qtmux: Add prores support

Or make it a list of allowed formats in the caps? Ok otherwise
Comment 5 Thibault Saunier 2015-10-13 20:30:31 UTC 
Attachment 313137 [details] pushed as 6bfee34 - qtmux: Add prores support
Comment 6 Thibault Saunier 2015-10-13 20:31:20 UTC 
Is backporting ok?
Comment 7 Tim-Philipp Müller 2015-10-14 08:08:08 UTC 
should be ok to backport, yes.