After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756131 - Disable can-fullscreen when going back, and simplify the state changes / signal emissions
Disable can-fullscreen when going back, and simplify the state changes / sign...
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.16.x
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
: 742747 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-10-06 16:04 UTC by Debarshi Ray
Modified: 2015-10-12 15:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
embed, mode-controller: Rearrange the code for subsequent fixes (2.11 KB, patch)
2015-10-06 16:06 UTC, Debarshi Ray 		committed Details | Review
mode-controller: Set the fullscreen policy when going back (2.39 KB, patch)
2015-10-06 16:07 UTC, Debarshi Ray 		committed Details | Review
mode-controller: Fix typo (2.19 KB, patch)
2015-10-06 16:10 UTC, Debarshi Ray 		committed Details | Review
mode-controller: Clean up the fullscreen code (5.03 KB, patch)
2015-10-06 16:10 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2015-10-06 16:04:11 UTC 
There are some bugs in the fullscreen code that the power of hindsight has fixed for us in gnome-documents:

a) We are not disabling can-fullscreen when going back to the overviews from the preview.

b) The fact that the mode changes between the emissions of can-fullscreen-changed and window-mode-changed is confusing. We should generally avoid racy situations like this so that we can easily enforce the invariants of our state machine.

We should cherry pick these fixes from gnome-documents.
Comment 1 Debarshi Ray 2015-10-06 16:06:38 UTC 
Created attachment 312742 [details] [review]
embed, mode-controller: Rearrange the code for subsequent fixes
Comment 2 Debarshi Ray 2015-10-06 16:07:15 UTC 
Created attachment 312743 [details] [review]
mode-controller: Set the fullscreen policy when going back
Comment 3 Debarshi Ray 2015-10-06 16:10:21 UTC 
Created attachment 312744 [details] [review]
mode-controller: Fix typo
Comment 4 Debarshi Ray 2015-10-06 16:10:48 UTC 
Created attachment 312746 [details] [review]
mode-controller: Clean up the fullscreen code
Comment 5 Alessandro Bono 2015-10-06 21:57:39 UTC 
These patches look good to me.
Comment 6 Debarshi Ray 2015-10-12 15:26:29 UTC 
*** Bug 742747 has been marked as a duplicate of this bug. ***