GNOME Bugzilla – Bug 75591
add format string to data_dir
Last modified: 2004-12-22 21:47:04 UTC
On Tue, Mar 19, 2002 at 10:24:25PM +0100, Hans Verkuil wrote: > First I want to say that Pan is probably the best news reader that I've used, > and I've tried a few. But even the best can be made better and there are two > features that I miss: > > The first feature request concerns the directory for saving attachments. By > default they go to News/Pan, or to the directory you supply yourself. I'd > really like to see a checkbox to set the default to News/<groupname>. I'm > pretty sure I've come across a similar feature in another newsreader and I > think it makes a lot of sense. I don't want to manually supply every group > with its own save directory. I like this idea, and we've danced around it before with undocumented features, but now that I think about it a format string for the Edit|Preferences|Directories|Save Directory field would be the cleanest way to solve this problem: %g would be group, etc, and a `help' button could show the format strings just as the date format entry fields do. [This would probably require a get_save_dir() function to do the substitution, just as get_data_dir() exists in 0.12.0.]
Hans Verkuil has a refinement to this suggestion at http://mail.freesoftware.fsf.org/pipermail/pan-users/2002-March/000063.html: ``If you want to make this really luxurious you could let the user choose whether to set the default to News/<group.name> or News/<group>/<name> (i.e. replacing the dots in a groupname by slashes). I remember that the newsreader (whose name I cannot remember :-) did have this feature.''
Fixed in CVS: http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan&command=DIFF_FRAMESET&file=save-ui.c&rev1=1.11&rev2=1.12&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan&command=DIFF_FRAMESET&file=prefs.c&rev1=1.256&rev2=1.257&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan&command=DIFF_FRAMESET&file=task-save.c&rev1=1.13&rev2=1.14&root=/cvs/gnome
Created attachment 8040 [details] [review] backport to gtk1 (apply with -p1)
'Lo, Here is a backport patch. Two issues however (applicable to gtk2 too, I think) : - if directory hierarchy doesn't exist, it isn't created ; - did you really mean to type "path_attachments" instead of "path_bodies" in task_save.c lines 271-272 ? Regards, Colin
See bug 80292 for the first issue.
The issues you raised are fixed in CVS now: http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan&command=DIFF_FRAMESET&file=task-save.c&rev1=1.14&rev2=1.15&root=/cvs/gnome Thanks for double-checking my work. It's amazing what a second pair of eyes will do. :)