After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 75591 - add format string to data_dir
add format string to data_dir
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
0.11.2.90
Other All
: Normal enhancement
: 0.12.0
Assigned To: Charles Kerr
Charles Kerr
Depends on:
Blocks:
 
 
Reported: 2002-03-20 13:57 UTC by Charles Kerr
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
backport to gtk1 (apply with -p1) (5.69 KB, patch)
2002-04-30 00:03 UTC, Colin Leroy
none Details | Review

Description Charles Kerr 2002-03-20 13:57:33 UTC
On Tue, Mar 19, 2002 at 10:24:25PM +0100, Hans Verkuil wrote:
> First I want to say that Pan is probably the best news reader that I've used,
> and I've tried a few. But even the best can be made better and there are two
> features that I miss:
>
> The first feature request concerns the directory for saving attachments. By
> default they go to News/Pan, or to the directory you supply yourself. I'd
> really like to see a checkbox to set the default to News/<groupname>. I'm
> pretty sure I've come across a similar feature in another newsreader and I
> think it makes a lot of sense. I don't want to manually supply every group
> with its own save directory.

I like this idea, and we've danced around it before with undocumented features,
but now that I think about it a format string for the 
Edit|Preferences|Directories|Save Directory field would be the cleanest
way to solve this problem: %g would be group, etc, and a `help' button
could show the format strings just as the date format entry fields do.

[This would probably require a get_save_dir() function to do the
substitution, just as get_data_dir() exists in 0.12.0.]
Comment 1 Charles Kerr 2002-03-21 15:10:51 UTC
Hans Verkuil has a refinement to this suggestion at
http://mail.freesoftware.fsf.org/pipermail/pan-users/2002-March/000063.html:

``If you want to make this really luxurious you could let
the user choose  whether to set the default to
News/<group.name> or News/<group>/<name> (i.e. replacing
the dots in a groupname by slashes). I remember that the 
newsreader (whose name I cannot remember :-) did have
this feature.'' 
Comment 3 Colin Leroy 2002-04-30 00:03:59 UTC
Created attachment 8040 [details] [review]
backport to gtk1 (apply with -p1)
Comment 4 Colin Leroy 2002-04-30 00:06:10 UTC
'Lo, 

Here is a backport patch. Two issues however (applicable to gtk2 too,
I think) : 
- if directory hierarchy doesn't exist, it isn't created ;
- did you really mean to type "path_attachments" instead of
"path_bodies" in task_save.c lines 271-272 ?

Regards,
Colin
Comment 5 Colin Leroy 2002-04-30 01:32:03 UTC
See bug 80292 for the first issue.
Comment 6 Charles Kerr 2002-04-30 15:34:04 UTC
The issues you raised are fixed in CVS now:
http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan&command=DIFF_FRAMESET&file=task-save.c&rev1=1.14&rev2=1.15&root=/cvs/gnome

Thanks for double-checking my work.
It's amazing what a second pair of eyes will do. :)