After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755108 - mssdemux: playback always starts at lowest bitrate
mssdemux: playback always starts at lowest bitrate
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.6.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-16 10:48 UTC by Philippe Normand
Modified: 2015-09-30 16:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mssdemux: activate streams before configuring bitrate (5.07 KB, patch)
2015-09-16 10:49 UTC, Philippe Normand
none Details | Review
mssdemux: activate streams before configuring bitrate (3.04 KB, patch)
2015-09-16 10:52 UTC, Philippe Normand
none Details | Review
mssdemux: activate streams before configuring bitrate (2.58 KB, patch)
2015-09-30 14:18 UTC, Philippe Normand
committed Details | Review

Description Philippe Normand 2015-09-16 10:48:47 UTC
In gst_mss_demux_setup_streams() we attempt to configure the bitrate on not-yet-active streams so gst_mss_manifest_change_bitrate() has no effect.

Instead I think we should first create the streams, activate them and then configure the bitrate. I'll send a patch.
Comment 1 Philippe Normand 2015-09-16 10:49:35 UTC
Created attachment 311447 [details] [review]
mssdemux: activate streams before configuring bitrate

Doing the contrary has no effect and the consequence is that playback
will start with the lowest bitrate even if we can already handle
higher bitrate.
Comment 2 Philippe Normand 2015-09-16 10:52:01 UTC
Created attachment 311448 [details] [review]
mssdemux: activate streams before configuring bitrate

Doing the contrary has no effect and the consequence is that playback
will start with the lowest bitrate even if we can already handle
higher bitrate.
Comment 3 Thiago Sousa Santos 2015-09-21 22:34:20 UTC
Review of attachment 311448 [details] [review]:

Good catch!

(For the record, it seems to depend on the patch here https://bugzilla.gnome.org/review?bug=753613)
Comment 4 Philippe Normand 2015-09-22 06:57:50 UTC
If neeed I can rebase the patch against current master. Thanks for the reviews Thiago :)
Comment 5 Philippe Normand 2015-09-29 17:01:42 UTC
I'll rebase this one against git master this week.
Comment 6 Philippe Normand 2015-09-30 14:18:16 UTC
Created attachment 312431 [details] [review]
mssdemux: activate streams before configuring bitrate

Doing the contrary has no effect and the consequence is that playback
will start with the lowest bitrate even if we can already handle
higher bitrate.


Same patch but rebased on current git master.
Comment 7 Tim-Philipp Müller 2015-09-30 15:56:27 UTC
commit bf1246cb1315caa48d7b9c2fd347206512a84a5f
Author: Philippe Normand <philn@igalia.com>
Date:   Wed Sep 16 12:50:46 2015 +0200

    mssdemux: activate streams before configuring bitrate
    
    Doing the contrary has no effect and the consequence is that playback
    will start with the lowest bitrate even if we can already handle
    higher bitrate.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=755108