After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753325 - rtpklv(de)pay: add "RTP" in the klass string
rtpklv(de)pay: add "RTP" in the klass string
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-06 15:59 UTC by George Kiagiadakis
Modified: 2015-08-16 13:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtpklv(de)pay: add "RTP" in the klass string (1.62 KB, patch)
2015-08-06 15:59 UTC, George Kiagiadakis
committed Details | Review

Description George Kiagiadakis 2015-08-06 15:59:01 UTC
Created attachment 308859 [details] [review]
rtpklv(de)pay: add "RTP" in the klass string

GstRTSPMedia uses this classification to detect the real payloader
inside a dynpay bin and asserts if it doesn't find it, therefore
it is required.

rtsp-media.c:2276:
   if (strstr (klass, "Payloader") && strstr (klass, "RTP")) {
Comment 1 Nicolas Dufresne (ndufresne) 2015-08-06 16:19:21 UTC
Review of attachment 308859 [details] [review]:

Make sense to me.
Comment 2 Sebastian Dröge (slomo) 2015-08-07 08:16:03 UTC
How did you manage to break the ü in Tim's name in the patch? :) Looks like a broken git config or something.


commit 2e590a32eb88da2e200e6180747de76ccbd7797c
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Thu Aug 6 17:46:13 2015 +0200

    rtpklv(de)pay: add "RTP" in the klass string
    
    GstRTSPMedia uses this classification to detect the real payloader
    inside a dynpay bin and asserts if it doesn't find it, therefore
    it is required
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753325
Comment 3 George Kiagiadakis 2015-08-07 08:31:57 UTC
(In reply to Sebastian Dröge (slomo) from comment #2)
> How did you manage to break the ü in Tim's name in the patch? :) Looks like
> a broken git config or something.
> 

Heh! :) No, it's a browser issue. The patch is correct on my file system and it is also shown correctly if go to patch review, but if you try to download it as plain text, the browser interprets it as Western encoding instead of Unicode. Just switch the browser's encoding manually.