After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752860 - [PATCH] SummaryInformation dates are parsed incorrectly
[PATCH] SummaryInformation dates are parsed incorrectly
Status: RESOLVED FIXED
Product: msitools
Classification: Other
Component: general
0.94
Other Linux
: Normal normal
: 1.0
Assigned To: msitools maintainer(s)
msitools maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-07-25 12:37 UTC by Stephen Kitt
Modified: 2016-12-20 09:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Log (924 bytes, text/x-log)
2015-07-25 12:37 UTC, Stephen Kitt 		  Details
Bug fix (subtract 1900 from tm.tm_year) (1.69 KB, patch)
2016-12-05 13:26 UTC, Stephen Kitt 		none Details | Review
Bug 752860 — correctly parse dates (1.69 KB, patch)
2016-12-20 09:34 UTC, Marc-Andre Lureau 		committed Details | Review

Description Stephen Kitt 2015-07-25 12:37:56 UTC 
Created attachment 308128 [details]
Log

Hi,

The _SummaryInformation test fails on 32-bit platforms (see https://buildd.debian.org/status/package.php?p=msitools&suite=unstable for details).

I'm attaching the log from an i386 build.

Regards,

Stephen
Comment 1 Stephen Kitt 2016-11-21 19:59:18 UTC 
https://github.com/GNOME/msitools/pull/1 fixes this.
Comment 2 Stephen Kitt 2016-12-05 13:26:05 UTC 
Created attachment 341397 [details] [review]
Bug fix (subtract 1900 from tm.tm_year)

The attached patch fixes the bug (tested in Debian).
Comment 3 Marc-Andre Lureau 2016-12-20 09:34:15 UTC 
The following fix has been pushed:
df915de Bug 752860 — correctly parse dates
Comment 4 Marc-Andre Lureau 2016-12-20 09:34:20 UTC 
Created attachment 342249 [details] [review]
Bug 752860 — correctly parse dates

In struct tm, tm_year is the year minus 1900; this patch fixes
parse_filetime() and correct the testsuite appropriately.

This fixes #752860 and allows the tests to pass on 32-bit
platforms (previously they failed because 3912 doesn't fit in 32-bit
time_t).

Signed-off-by: Stephen Kitt <steve@sk2.org>