After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 752620 - dashdemux: segment start time and duration could overflow
dashdemux: segment start time and duration could overflow
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-07-20 09:49 UTC by Florin Apostol
Modified: 2015-08-16 13:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (2.40 KB, patch)
2015-07-20 09:51 UTC, Florin Apostol
committed Details | Review

Description Florin Apostol 2015-07-20 09:49:25 UTC
Computation of segment start time and duration could overflow. gst_util_uint64_scale function should be used to avoid this.
Comment 1 Florin Apostol 2015-07-20 09:51:05 UTC
Created attachment 307741 [details] [review]
proposed patch
Comment 2 Thiago Sousa Santos 2015-07-24 13:10:30 UTC
commit 90b7c137b6d192fff3b357714844ee7a02467e11
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Mon Jul 20 10:50:44 2015 +0100

    dahdemux: avoid overflows in computation of segment start time and duration
    
    Used gst_util_uint64_scale to avoid overflows when segment start time
    or duration is computed.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=752620