After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751496 - rtspsrc: Add new ntp-time-source property and deprecate use-pipeline-clock property
rtspsrc: Add new ntp-time-source property and deprecate use-pipeline-clock pr...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-25 13:03 UTC by Hyunjun Ko
Modified: 2015-08-16 13:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtspsrc: Add new ntp-time-source property and deprecate use-pipeline-clock property (5.91 KB, patch)
2015-06-25 13:07 UTC, Hyunjun Ko
none Details | Review
rtpbin/session: fix description (1.78 KB, patch)
2015-06-25 14:21 UTC, Hyunjun Ko
committed Details | Review
rtpbin/session: fix descriptiontspsrc: Add new ntp-time-source property and deprecate use-pipeline-clock property (6.00 KB, patch)
2015-06-25 15:11 UTC, Hyunjun Ko
committed Details | Review

Description Hyunjun Ko 2015-06-25 13:03:30 UTC
Recently, ntp-time-source is added to rtpbin/rtpsession. 
Also this new property needs to be added to rtspsrc.
Comment 1 Hyunjun Ko 2015-06-25 13:07:31 UTC
Created attachment 306102 [details] [review]
rtspsrc: Add new ntp-time-source property and deprecate use-pipeline-clock property

I'm not sure whether it's correct that set FALSE to use-pipeline-clock once nth-time-source is set.
Comment 2 Hyunjun Ko 2015-06-25 14:21:14 UTC
Created attachment 306114 [details] [review]
rtpbin/session: fix description
Comment 3 Sebastian Dröge (slomo) 2015-06-25 14:31:07 UTC
Review of attachment 306102 [details] [review]:

::: gst/rtsp/gstrtspsrc.c
@@ +3423,3 @@
+          g_object_set (src->manager, "use-pipeline-clock", FALSE, NULL);
+        }
+      }

The code a few lines above is still always setting use-pipeline-clock to something. I think the logic should be like in rtpbin:

if (src->use_pipeline_clock) {
  g_object_set (manager, "use-pipeline-clock", TRUE, NULL);
} else {
  g_object_set (manager, "ntp-time-source", src->ntp_time_source, NULL);
}
Comment 4 Hyunjun Ko 2015-06-25 15:11:03 UTC
Created attachment 306116 [details] [review]
rtpbin/session: fix descriptiontspsrc: Add new ntp-time-source property and deprecate use-pipeline-clock property

Following slum's review.
Comment 5 Sebastian Dröge (slomo) 2015-06-25 15:17:17 UTC
Comment on attachment 306116 [details] [review]
rtpbin/session: fix descriptiontspsrc: Add new ntp-time-source property and deprecate use-pipeline-clock property

commit f560a3d223d5623fc184d8a2a62cb8bbc295d11b
Author: Hyunjun Ko <zzoon.ko@samsung.com>
Date:   Fri Jun 26 00:05:29 2015 +0900

    rtspsrc: Add new ntp-time-source property and deprecate use-pipeline-clock property
    
    Enable to use new ntp-time-source property of rtpbin
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751496
Comment 6 Sebastian Dröge (slomo) 2015-06-25 15:18:21 UTC
commit f560a3d223d5623fc184d8a2a62cb8bbc295d11b
Author: Hyunjun Ko <zzoon.ko@samsung.com>
Date:   Fri Jun 26 00:05:29 2015 +0900

    rtspsrc: Add new ntp-time-source property and deprecate use-pipeline-clock property
    
    Enable to use new ntp-time-source property of rtpbin
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751496