After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751260 - Fails to add new connection: JS ERROR: TypeError: this._serverEntry is undefined
Fails to add new connection: JS ERROR: TypeError: this._serverEntry is undefined
Status: RESOLVED NOTABUG
Product: polari
Classification: Applications
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-20 14:11 UTC by Michael Biebl
Modified: 2015-06-22 14:58 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michael Biebl 2015-06-20 14:11:23 UTC
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=789372
Version: 3.16.1

With gjs version 1.42, polari fails to add new connections with the following error message:


| (org.gnome.Polari:9510): Gjs-WARNING **: JS ERROR: TypeError:
| this._serverEntry is undefined
| ConnectionDetails<._init@resource:///org/gnome/Polari/js/connections.js:190
| wrapper@resource:///org/gnome/gjs/modules/lang.js:169
| JoinDialog<._createWidget@resource:///org/gnome/Polari/js/joinDialog.js:73
| wrapper@resource:///org/gnome/gjs/modules/lang.js:169
| JoinDialog<._init@resource:///org/gnome/Polari/js/joinDialog.js:22
| wrapper@resource:///org/gnome/gjs/modules/lang.js:169
| _Base.prototype._construct@resource:///org/gnome/gjs/modules/lang.js:110
| Class.prototype._construct/newClass@resource:///org/gnome/gjs/modules/lang.js:204
| MainWindow<.showJoinRoomDialog@resource:///org/gnome/Polari/js/mainWindow.js:233
| wrapper@resource:///org/gnome/gjs/modules/lang.js:169
| Application<._onShowJoinDialog@resource:///org/gnome/Polari/js/application.js:187
| wrapper@resource:///org/gnome/gjs/modules/lang.js:169
| main@resource:///org/gnome/Polari/js/main.js:17
| run@resource:///org/gnome/gjs/modules/package.js:192
| start@resource:///org/gnome/gjs/modules/package.js:176
| @/usr/bin/polari:5


Upgrading gjs to 1.43.3 fixes this issue.
Ideally, polari should work with older gjs versions, but if that's not easily possible, this requirement should at least be documented in NEWS and/or have configure check for a new enough version.
Comment 1 Florian Müllner 2015-06-22 14:58:08 UTC
(In reply to Michael Biebl from comment #0)
> Ideally, polari should work with older gjs versions

Dependencies aren't bumped arbitrarily, but if a dependencies gains interesting functionality during a development cycle (like support for GTK templates in this case), I don't see a reason not to use it - polari x.y is clearly targeting GNOME x.y, and while a release may work with a previous GNOME version, this is not a goal in itself.


> this requirement should at least be documented in NEWS

Yeah, sorry I missed that - the move to GTK templates didn't have associated bugs, so my NEWS template script missed it.


> and/or have configure check for a new enough version.

It's a runtime dependency, so no configure check.


There isn't anything actionable here (apart from trying harder to not miss changes like this in NEWS in the future), so going to close this.