GNOME Bugzilla – Bug 748717
Filter by font - layout and visual fixes
Last modified: 2017-09-23 16:31:58 UTC
The popover for selecting a font to filter by works great, but there are some visual issues that mean it is a bit untidy. * The list should have the same width as the search box, so they are aligned. * The list should have a border. Ideally, there should be separators between each line. * There needs to be more horizontal padding around the search box, so it isn't so close to the edges of the popover.
Thanks, that should be fixed now: https://git.gnome.org/browse/gnome-characters/commit/?id=f0e7f026b6f741116d5cdb8a0e9b71b0e6e356e4
Created attachment 320734 [details] screenshot Some of these issues weren't fixed when I tested with GNOME Continuous yesterday. See the attached screenshot: * The search bar has a different width from the list. * Not enough padding on the left and right of the list. * Not enough padding around the row labels, and the rows aren't tall enough. feels quite squashed. * "Filter by font" doesn't look like a heading. Changes I'd suggest to fix this: * Add 12px left and right margin to menu-grid. * Give the search box the same width as the list below. * Increase the padding around the labels in each row of the list (maybe to 6px). This has the desirable effect of increasing the height of the rows. * Use header capitalization for "filter by font" (so it reads "Filter by Font"), and make it bold.
Reopening.
Thanks for reporting that (and the suggestions). I've pushed a fix: https://git.gnome.org/browse/gnome-characters/commit/?id=1e5cf7c6847989b4562062b6079b1d96c82ad3ef The padding issue seems to be a regression after recent CSS name changes in GTK+, to which I have adjusted the code.
Looks much better - thanks Daiki!
Closing as resolved now.