GNOME Bugzilla – Bug 748353
rtspsrc: Leak of RTCP caps
Last modified: 2015-04-23 14:12:24 UTC
Created attachment 302204 [details] [review] rtspsrc: Fix RTCP caps leak Running a pipeline containing rtspsrc through Valgrind gave me this ==11275== 200 (72 direct, 128 indirect) bytes in 1 blocks are definitely lost in loss record 4,270 of 4,457 ==11275== at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==11275== by 0x53EB560: g_malloc (gmem.c:97) ==11275== by 0x540123D: g_slice_alloc (gslice.c:1007) ==11275== by 0x4E7710E: gst_caps_new_empty (gstcaps.c:243) ==11275== by 0x4E7721D: gst_caps_new_empty_simple (gstcaps.c:288) ==11275== by 0x73E22FD: gst_rtspsrc_handle_data (gstrtspsrc.c:4632) ==11275== by 0x73EDFDE: gst_rtspsrc_thread (gstrtspsrc.c:4799) ==11275== by 0x4ED0048: gst_task_func (gsttask.c:331) ==11275== by 0x540B9BB: g_thread_pool_thread_proxy (gthreadpool.c:307) ==11275== by 0x540B034: g_thread_proxy (gthread.c:764) ==11275== by 0x56DB181: start_thread (pthread_create.c:312) ==11275== by 0x59EB47C: clone (clone.S:111) Runnning gst-plugins-good at edcc5be Looks like this commit removed a bit too much http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit?id=b4aaa11f9733ba1800f7e88e3de911404aee7b11 Attached is a patch that unrefs the leaked caps.
Pushed, thanks for the patch! commit 3528046773c3c179751c1e727f9a13369d5578ed Author: Jesper Larsen <knorr.jesper@gmail.com> Date: Thu Apr 23 09:55:59 2015 +0200 rtspsrc: Fix RTCP caps leak https://bugzilla.gnome.org//show_bug.cgi?id=748353