After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 74830 - GtkCheckButton doesn't draw focus when it doesn't have a child
GtkCheckButton doesn't draw focus when it doesn't have a child
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.0.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 87919 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2002-03-15 19:33 UTC by Dave Camp
Modified: 2011-02-04 16:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A fix that draws the focus around the checkbutton when there is no child. (1.68 KB, patch)
2002-03-15 19:34 UTC, Dave Camp 		none Details | Review
patch as applied (10.77 KB, patch)
2002-10-17 20:21 UTC, Owen Taylor 		none Details | Review

Description Dave Camp 2002-03-15 19:33:39 UTC 
when interior_focus is TRUE and the GtkCheckButton doesn't have a child
widget, it doesn't draw focus.
Comment 1 Dave Camp 2002-03-15 19:34:37 UTC 
Created attachment 7193 [details] [review]
A fix that draws the focus around the checkbutton when there is no child.
Comment 2 Owen Taylor 2002-03-20 23:29:23 UTC 
What's the use case for check buttons without children?
Comment 3 Dave Camp 2002-03-21 00:02:56 UTC 
Nautilus uses them in the file properties dialog, in the permissions tab.
Comment 4 Matthias Clasen 2002-04-05 13:34:59 UTC 
Move open bugs from milestones 2.0.[012] -- > 2.0.3, since 2.0.2 is already out.
Comment 5 Damon Chaplin 2002-07-11 17:48:04 UTC 
Glade also uses them besides optional properties, so I'd like to see
the patch go in.
Comment 6 Owen Taylor 2002-07-16 16:27:43 UTC 
*** Bug 87919 has been marked as a duplicate of this bug. ***
Comment 7 Calum Benson 2002-08-13 10:54:43 UTC 
Owen, did this fix go into one of the recent gtk releases, or did I
just imagine it...?  :/
Comment 8 Owen Taylor 2002-10-17 20:20:43 UTC 
Calum: note the sun_patches keyword.

I've now gone ahead and made this change for the HEAD branch.
I needed somewhat more extensive changes than the original
patch... too much space was being allocated and the indicator
was positioned in the wrong place.

I also added tests for check and radio buttons to testgtk.c.

Thu Oct 17 16:13:28 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/gtkcheckbutton.c gtk/gtkradiobutton.c: Make
        the widgets work reasonably when they don't have
        children -- draw the focus around the indicator,
        and position the indicator symmetrically.
        (#74830, Dave Camp)

        * tests/testgtk.c: Add no-child portions to check and radio
        button tests.
Comment 9 Owen Taylor 2002-10-17 20:21:10 UTC 
Created attachment 11645 [details] [review]
patch as applied