After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 748058 - autogen.sh fails due to autopoint erroring out due to missing gettext version in configure.ac
autogen.sh fails due to autopoint erroring out due to missing gettext version...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-04-17 14:48 UTC by Vincent Penquerc'h
Modified: 2015-04-26 14:09 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Vincent Penquerc'h 2015-04-17 14:48:36 UTC
./autogen.sh 
+ check for build tools
  checking for autoreconf >= 2.68 ... found 2.68, ok.
  checking for pkg-config >= 0.8.0 ... found 0.26, ok.
+ checking for autogen.sh options
  This autogen script will automatically run ./configure as:
  ./configure --enable-maintainer-mode --enable-gtk-doc
  To pass any additional options, please specify them on the ./autogen.sh
  command line.
+ running autopoint --force...
autopoint: *** Missing version: please specify in configure.ac through a line 'AM_GNU_GETTEXT_VERSION(x.yy.zz)' the gettext version the package is using
autopoint: *** Stop.

autopoint failed


Looking at configure.ac, there version number is commented out (from bff66c00041b9b009f7e10f294f3ae683737bfb7). Uncommenting it makes autogen.sh work (may not as expected since the commit message says it's broken though).
Comment 1 Sebastian Dröge (slomo) 2015-04-17 15:19:25 UTC
Does just adding 0.17 there make it work with 0.17 and newer versions?
Comment 2 Vincent Penquerc'h 2015-04-17 15:23:23 UTC
It seems to work fine with 0.18.1, the one I have, at least. gst-rtsp-server builds fine, and seems to work fine with those lines uncommented.
Comment 3 Sebastian Dröge (slomo) 2015-04-17 15:24:23 UTC
My point is, can you give an older version there and then it also works with newer versions?
Comment 4 Vincent Penquerc'h 2015-04-17 15:52:08 UTC
Not sure what you mean, sorry. I tested with 0.17 in configure.ac, and 0.18.1 installed (so a setting of 0.17 works with at least that particular newer version).
Comment 5 Sebastian Dröge (slomo) 2015-04-17 17:04:08 UTC
Seems the right thing to do then
Comment 6 Vincent Penquerc'h 2015-04-20 07:53:48 UTC
I quoted the wrong commit hash above, the commenting out was in de30acfd3d9655d3819348d53d3977c8e69ac5d3. In any case, the mention of the setup being broken was probably fixed by bff66c00041b9b009f7e10f294f3ae683737bfb7, which removed some autopoint related tweaks of the build tree, so it seems best to uncomment indeed:

commit 1545d8fef7065081079172ec264a0061039ac075
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Mon Apr 20 08:49:57 2015 +0100

    configure.ac: uncomment gettext version setup
    
    Fixes autogen.sh. It would run autopoint, which would complain
    that it could not find the gettext version in configure.ac.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748058
Comment 7 Tim-Philipp Müller 2015-04-20 10:48:13 UTC
I don't get this. Why is autopoint run? It should only be run if there is a po/ directory, but there should be no po/ directory (any more).

Seeing that those commits you referenced are mine it would have been nice if you had quickly checked with me.

I don't think this commit makes sense like this, since we don't have or need a gettext setup for this module.
Comment 8 Vincent Penquerc'h 2015-04-20 10:57:08 UTC
Interesting. I have a po directory. If I remove it and the patch, it works fine.
With the patch, the po directory is recreated. I guess this is what happened at some point in the past, the po directory got created, when it should not have been ?
In any case, if po isn't needed, I will revert my patch since it all works without it present (soon, waiting for any further comment first).
Comment 9 Tim-Philipp Müller 2015-04-23 13:51:24 UTC
I'm not sure what happened in your case or why you had a po directory, but I think we should just remove anything gettext related from gst-rtsp-server, I don't see a need for it to have translatable strings.
Comment 10 Tim-Philipp Müller 2015-04-23 13:52:05 UTC
perhaps the autogen.sh check should also be improved to check for the gettext stuff in configure.ac in addition to the presence of the po directory, before running autopoint.
Comment 11 Tim-Philipp Müller 2015-04-26 14:09:18 UTC
Let's try this then:

commit f777de7d7f33b4982bdf39db59b4680482bcea3a
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Sun Apr 26 15:00:05 2015 +0100

    autogen.sh: only run autopoint if gettext requested in configure.ac
    
    Not just because there happens to be a po directory.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=748058

commit 226fbbc8f8540ee53c29366ed70c7beb0a0d7e21
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Sun Apr 26 14:58:49 2015 +0100

    Revert "configure.ac: uncomment gettext version setup"
    
    This reverts commit 1545d8fef7065081079172ec264a0061039ac075.
    
    We don't need a gettext setup here and there's no po
    directory either, so no reason why autopoint would be
    run in the first place.
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=748058