After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 74771 - no thumbnails if thumbnail_limit key exists, regardless of value
no thumbnails if thumbnail_limit key exists, regardless of value
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Thumbnails
0.x.x [obsolete]
Other other
: High major
: 1.1.x
Assigned To: Michael Meeks
Nautilus Maintainers
: 76596 77925 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2002-03-15 13:08 UTC by Arafat Medini
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.0


Attachments
Proposed patch to get enum instead of get integer for thumbnail_limit (838 bytes, text/plain)
2002-04-03 12:19 UTC, Brian Nitz
Details

Description Arafat Medini 2002-03-15 13:09:12 UTC
Package: nautilus
Severity: normal
Version: latest
Synopsis: no thumbnails 
Bugzilla-Product: nautilus
Bugzilla-Component: Thumbnails

Description:
Description of Problem:
I don't have any thumbnails for all my pics after changing the prefrence
of the filesize 
from making no thumbnail for files bigger then 5 megs to making no
thumbnails for files bigger then 1 meg 
Steps to reproduce the problem:
1. 
2. 
3. 

Actual Results:


Expected Results:


How often does this happen?


Additional Information:




------- Bug moved to this database by unknown@bugzilla.gnome.org 2002-03-15 08:09 -------

Reassigning to the default owner of the component, nautilus-maint@bugzilla.gnome.org.

Comment 1 Dave Bordoley [Not Reading Bug Mail] 2002-03-16 10:09:05 UTC
Are all your image file less than 1 meg? If not than this is not a bug.
Comment 2 Luis Villa 2002-03-18 18:03:18 UTC
I'm seeing it too, Dave. Definitely a regression from 1.0.x. 

Michael: please don't add triaged to new bugs unless you cc: me when
you add triaged. Thanks.
Comment 3 Dave Bordoley [Not Reading Bug Mail] 2002-03-27 21:56:25 UTC
*** Bug 76596 has been marked as a duplicate of this bug. ***
Comment 4 Andreas Persenius 2002-03-29 21:01:13 UTC
I'm also seeing this with a fresh build from CVS (March 29th,
2002).

It's easily reproducible:
1) Open a folder window with a couple of images.
2) Choose Edit -> Preferences
3) Go to Speed Tradeoffs
4) Choose a file size in the "Don't make thumbnails for files larger
than" menu. (It doesn't matter what you choose here).
5) Watch all thumbnails turn into ordinary file type icons.

To fix it, delete the GConf key
/apps/nautilus/preferences/thumbnail_limit:

   gconftool-2 -u /apps/nautilus/preferences/thumbnail_limit

..all images immediately regain their thumbnails. (With the older
Nautilus in GARNOME 0.8.0 you had to logout and back in again for
the thumbnails to appear.)
Comment 5 Luis Villa 2002-03-29 21:13:25 UTC
That doesn't help here. :/
Comment 6 Andreas Persenius 2002-03-29 21:27:42 UTC
Ok, that's strange. On my system, as soon as I change that GConf key
(/apps/nautilus/preferences/thumbnail_limit) all thumbnails disappear
and won't come back until I delete the key (either by hand editing the
file or with gconftool-2).
Comment 7 Tuomas Kuosmanen 2002-03-29 22:00:31 UTC
AARGH! This is exactly what happens here. So doing the gcontool thing
to delete the key fixed it. And it borks right away when I set the
limit again.

Comment 8 John Fleck 2002-03-31 15:32:42 UTC
This is now working correctly for me. cvs build of Friday night, 3/29.
Could others verify and close if they're not seeing the problem any
more either?
Comment 9 Luis Villa 2002-03-31 17:08:35 UTC
OK, I'm now getting it to work by unsetting the key. It's still broken
if the key is set at all. Retitling.
Comment 10 Brian Nitz 2002-04-02 08:51:36 UTC
Still broken as of the 1 April CVS Head.
The following error is logged whenever a change is made to this value:

 Eel-CRITICAL **: file eel-preferences.c: line 97: assertion
`value->type == GCONF_VALUE_INT' failed

Thumbnails disappear and don't reappear until key is manually removed.
Comment 11 Tuomas Kuosmanen 2002-04-02 09:43:54 UTC
Just an interesting observation: thumbnails work, and you can even
set a limit if you use gconf-editor to do that, but it borks if you
set that preferences from Nautilus..? Does nautilus set it somehow
differently, or does it set something else in the process?

Setting the thumbnail limits from gconf-editor works fine and does not
kill thumbnailing.
Comment 12 Brian Nitz 2002-04-02 10:46:05 UTC
Still broken as of the 1 April CVS Head.
The following error is logged whenever a change is made to this value:

 Eel-CRITICAL **: file eel-preferences.c: line 97: assertion
`value->type == GCONF_VALUE_INT' failed

But thumbnail_limit is stored as a string:

<gconf><entry name="thumbnail_limit" mtime="1017737163" muser="gnome2"
type="string"><stringvalue>3145728</stringvalue></entry></gconf>

Was this intended to allow limits larger than a 32 bit int?
This does explain Tigert's observation.  
Comment 13 Brian Nitz 2002-04-03 12:19:09 UTC
Created attachment 7528 [details]
Proposed patch to get enum instead of get integer for thumbnail_limit
Comment 14 Brian Nitz 2002-04-04 16:21:40 UTC
A build of nautilus with the changes in the proposed patch did fix
this problem.
Comment 15 Darin Adler 2002-04-04 16:42:47 UTC
I think this was just a snafu when Michael Meeks changed preferences
around. I remember him mentioning enums vs. ints at that time.

Michael, can you take care of this?
Comment 16 John Fleck 2002-04-07 15:00:16 UTC
*** Bug 77925 has been marked as a duplicate of this bug. ***
Comment 17 Alexander Larsson 2002-04-07 19:44:13 UTC
Now fixed in cvs.