After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747252 - provide a scalable -symbolic variant of the app icon
provide a scalable -symbolic variant of the app icon
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-04-02 15:02 UTC by Jakub Steiner
Modified: 2015-04-13 12:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
icon: provide a symbolic variant of the app icon (4.95 KB, patch)
2015-04-02 15:03 UTC, Jakub Steiner
none Details | Review
icon: provide a symbolic variant of the app icon (5.38 KB, patch)
2015-04-13 12:13 UTC, Bastien Nocera
committed Details | Review

Description Jakub Steiner 2015-04-02 15:02:55 UTC
Starting with GNOME 3.16 we streamlined how high contrast icons are managed. The attached patch includes a symbolic variant of the app icon that is used for HC theme and recolorable at runtime.

See https://wiki.gnome.org/Initiatives/GnomeGoals/HighContrastAppIcons for more details.
Comment 1 Jakub Steiner 2015-04-02 15:03:20 UTC
Created attachment 300826 [details] [review]
icon: provide a symbolic variant of the app icon

Since 3.16 the high contrast accessible theme is
covered by the recolorable symbolic variant of the app icon.

The symbolic size has been introduced to hicolor to cope with
the nominal size of 16x16 rather than the backward compatible
128x128.
Comment 2 Bastien Nocera 2015-04-02 15:08:53 UTC
Review of attachment 300826 [details] [review]:

Looks good!
Comment 3 Philip Withnall 2015-04-11 23:45:03 UTC
Review of attachment 300826 [details] [review]:

::: configure.ac
@@ +591,3 @@
 data/icons/256x256/Makefile
 data/icons/scalable/Makefile
+data/icons/symbolic/Makefile

This file (data/icons/symbolic/Makefile.am) is missing from the patch.
Comment 4 Bastien Nocera 2015-04-13 12:13:28 UTC
Created attachment 301452 [details] [review]
icon: provide a symbolic variant of the app icon

Since 3.16 the high contrast accessible theme is
covered by the recolorable symbolic variant of the app icon.

The symbolic size has been introduced to hicolor to cope with
the nominal size of 16x16 rather than the backward compatible
128x128.
Comment 5 Bastien Nocera 2015-04-13 12:15:37 UTC
Attachment 301452 [details] pushed as 9437e11 - icon: provide a symbolic variant of the app icon