After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747238 - provide a scalable -symbolic variant of the app icon
provide a scalable -symbolic variant of the app icon
Status: RESOLVED FIXED
Product: hitori
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: hitori-maint
hitori-maint
Depends on:
Blocks:
 
 
Reported: 2015-04-02 13:10 UTC by Jakub Steiner
Modified: 2015-04-28 13:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
icon: provide a symbolic variant of teh app icon (8.94 KB, patch)
2015-04-02 13:10 UTC, Jakub Steiner
committed Details | Review

Description Jakub Steiner 2015-04-02 13:10:04 UTC
Starting with GNOME 3.16 we streamlined how high contrast icons are managed. The attached patch includes a symbolic variant of the app icon that is used for HC theme and recolorable at runtime.

See https://wiki.gnome.org/Initiatives/GnomeGoals/HighContrastAppIcons for more details.
Comment 1 Jakub Steiner 2015-04-02 13:10:34 UTC
Created attachment 300812 [details] [review]
icon: provide a symbolic variant of teh app icon

since 3.16 the high contrast accessible theme is
covered by the recolorable symbolic variant of the app icon.

The symbolic size has been introduced to hicolor to cope with
the nominal size of 16x16 rather than the backward compatible
128x128.
Comment 2 Arnaud B. 2015-04-02 17:02:16 UTC
There’s an error in the installation directory, I think. It should be “scalable”, not “symbolic”.
Comment 3 Philip Withnall 2015-04-11 23:27:50 UTC
Review of attachment 300812 [details] [review]:

The icon looks a bit like a window (in a building) to me. Maybe if it used a 3×3 grid, rather than 2×2, it would be more recognisable? Would there be enough space for that?

::: Makefile.am
@@ +62,3 @@
 icon48_DATA = data/icons/48x48/hitori.png
+iconsymbolicdir = $(icon_dir)/symbolic/apps
+iconsymbolic_DATA = data/icons/symbolic/hitori-symbolic.svg

As Arnaud says, this should be $(icon_dir)/scalable.
Comment 4 Michael Catanzaro 2015-04-28 00:25:34 UTC
(In reply to Arnaud Bonatti from comment #2)
> There’s an error in the installation directory, I think. It should be
> “scalable”, not “symbolic”.

That's actually not an error; the symbolic directory is just a new place for symbolic icons. The fun is now that we have half the new symbolics in one directory, and half in another. :)
Comment 5 Philip Withnall 2015-04-28 05:56:43 UTC
(In reply to Michael Catanzaro from comment #4)
> (In reply to Arnaud Bonatti from comment #2)
> > There’s an error in the installation directory, I think. It should be
> > “scalable”, not “symbolic”.
> 
> That's actually not an error; the symbolic directory is just a new place for
> symbolic icons. The fun is now that we have half the new symbolics in one
> directory, and half in another. :)

Oh, so which one’s correct? Symbolic? If so, Jakub, please commit.
Comment 6 Matthias Clasen 2015-04-28 13:05:13 UTC
Attachment 300812 [details] pushed as 7a8ffb3 - icon: provide a symbolic variant of teh app icon