After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747126 - androidmedia: add support for more color formats
androidmedia: add support for more color formats
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-31 16:39 UTC by Matthieu Bouron
Modified: 2015-05-04 10:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
androidmedia: Add suport for Intel color formats (2.47 KB, patch)
2015-03-31 16:40 UTC, Matthieu Bouron
committed Details | Review
androidmedia: Add support for COLOR_FormatYUV420Flexible (1.93 KB, patch)
2015-03-31 16:41 UTC, Matthieu Bouron
committed Details | Review
androidmedia: Add basic support for QOMX_COLOR_FORMATYVU420PackedSemiPlanar32mMultiView (2.99 KB, patch)
2015-03-31 16:41 UTC, Matthieu Bouron
none Details | Review
androidmedia: Declare QOMX_COLOR_FORMATYVU420PackedSemiPlanar32mMultiView constant (1.26 KB, patch)
2015-04-30 09:47 UTC, Matthieu Bouron
committed Details | Review
androidmedia: Add support for COLOR_FormatYV12 (2.08 KB, patch)
2015-05-03 13:00 UTC, Matthieu Bouron
committed Details | Review

Description Matthieu Bouron 2015-03-31 16:39:58 UTC
The following patchset add support for various color formats.
Comment 1 Matthieu Bouron 2015-03-31 16:40:34 UTC
Created attachment 300684 [details] [review]
androidmedia: Add suport for Intel color formats
Comment 2 Matthieu Bouron 2015-03-31 16:41:00 UTC
Created attachment 300685 [details] [review]
androidmedia: Add support for COLOR_FormatYUV420Flexible
Comment 3 Matthieu Bouron 2015-03-31 16:41:36 UTC
Created attachment 300686 [details] [review]
androidmedia: Add basic support for QOMX_COLOR_FORMATYVU420PackedSemiPlanar32mMultiView
Comment 4 Matthieu Bouron 2015-04-30 09:47:16 UTC
Created attachment 302636 [details] [review]
androidmedia: Declare QOMX_COLOR_FORMATYVU420PackedSemiPlanar32mMultiView constant

Patch updated: only declare the relevant constant and do not try to implement partial support without any testing due to the lack of relevant samples (H264/MVC) and supports in h264parse.
Comment 5 Matthieu Bouron 2015-05-03 13:00:41 UTC
Created attachment 302807 [details] [review]
androidmedia: Add support for COLOR_FormatYV12

The following patch is untested due to lack of proper device.
It happens to be found on tegra2 devices.
Comment 6 Sebastian Dröge (slomo) 2015-05-04 07:35:17 UTC
Comment on attachment 302636 [details] [review]
androidmedia: Declare QOMX_COLOR_FORMATYVU420PackedSemiPlanar32mMultiView constant

What's the point of adding this constant but not using it?
Comment 7 Sebastian Dröge (slomo) 2015-05-04 07:36:33 UTC
Comment on attachment 302807 [details] [review]
androidmedia: Add support for COLOR_FormatYV12

YV12 is in YVU order, not YUV. So not exactly the same as I420 and the others. You might need to swap the planes.
Comment 8 Matthieu Bouron 2015-05-04 10:34:04 UTC
(In reply to Sebastian Dröge (slomo) from comment #6)
> Comment on attachment 302636 [details] [review] [review]
> androidmedia: Declare QOMX_COLOR_FORMATYVU420PackedSemiPlanar32mMultiView
> constant
> 
> What's the point of adding this constant but not using it?

So we know what its value stands for as it is not part of the documentation and I had trouble finding what it was meaning. It is reported by my nexus5 device (android 5.1).


(In reply to Sebastian Dröge (slomo) from comment #7)
> Comment on attachment 302807 [details] [review] [review]
> androidmedia: Add support for COLOR_FormatYV12
> 
> YV12 is in YVU order, not YUV. So not exactly the same as I420 and the
> others. You might need to swap the planes.

It is covered under the same case as COLOR_FormatYUV420Planar and COLOR_FormatYUV420Flexible to compute the frame_size and it is mapped to GST_VIDEO_FORMAT_YV12 in color_format_mapping_table[]. Isn't it enough ?
I'm not a huge fan at sending this kind of patch without testing but I don't have the relevant device.
Comment 9 Sebastian Dröge (slomo) 2015-05-04 10:45:55 UTC
Comment on attachment 302807 [details] [review]
androidmedia: Add support for COLOR_FormatYV12

Makes sense and should be correct indeed. In the worst case the colors are wrong now and we get a report about that, still more useful then getting a report about codecs not working at all :)