After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747025 - provide a scalable -symbolic variant of the app icon
provide a scalable -symbolic variant of the app icon
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-chess-maint
gnome-chess-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-30 13:25 UTC by Jakub Steiner
Modified: 2015-04-30 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
icon: provice a symbolic variant of the app icon (11.55 KB, patch)
2015-03-30 13:27 UTC, Jakub Steiner
none Details | Review
icon: provice a symbolic variant of the app icon (11.55 KB, patch)
2015-04-30 15:31 UTC, Jakub Steiner
committed Details | Review

Description Jakub Steiner 2015-03-30 13:25:56 UTC
Starting with GNOME 3.16 we streamlined how high contrast icons are managed. The attached patch includes a symbolic variant of the app icon that is used for HC theme and recolorable at runtime.

See https://wiki.gnome.org/Initiatives/GnomeGoals/HighContrastAppIcons for more details.
Comment 1 Jakub Steiner 2015-03-30 13:27:13 UTC
Created attachment 300590 [details] [review]
icon: provice a symbolic variant of the app icon

since 3.16 used for the recolorable high contrast theme
Comment 2 Sahil Sareen 2015-03-30 13:58:18 UTC
Review of attachment 300590 [details] [review]:

Thanks for the patch!

::: data/icons/hicolor/scalable/gnome-chess-symbolic.svg
@@ +8,3 @@
+        <dc:format>image/svg+xml</dc:format>
+        <dc:type rdf:resource='http://purl.org/dc/dcmitype/StillImage'/>
+        <dc:title>Gnome Symbolic Icon Theme</dc:title>

Shouldn't this be called "GNOME Chess Icon" instead?

@@ +12,3 @@
+    </rdf:RDF>
+  </metadata>
+  <sodipodi:namedview inkscape:bbox-paths='true' bordercolor='#666666' borderopacity='1' inkscape:current-layer='layer9' inkscape:cx='12.658349' inkscape:cy='11.769974' gridtolerance='10' inkscape:guide-bbox='true' guidetolerance='10' id='namedview88' inkscape:object-nodes='false' inkscape:object-paths='false' objecttolerance='10' pagecolor='#555753' inkscape:pageopacity='1' inkscape:pageshadow='2' showborder='false' showgrid='true' showguides='true' inkscape:snap-bbox='true' inkscape:snap-bbox-midpoints='false' inkscape:snap-global='true' inkscape:snap-grids='true' inkscape:snap-nodes='true' inkscape:snap-others='false' inkscape:snap-to-guides='true' inkscape:window-height='1376' inkscape:window-maximized='1' inkscape:window-width='2560' inkscape:window-x='0' inkscape:window-y='27' inkscape:zoom='45.254834'>

This line is insanely long, GNOME recommends 120 characters in a line.
Probably because of inkscape :(

@@ +15,3 @@
+    <inkscape:grid empspacing='2' enabled='true' id='grid4866' originx='-62.000016' originy='-321.99999' snapvisiblegridlinesonly='true' spacingx='1px' spacingy='1px' type='xygrid' visible='true'/>
+  </sodipodi:namedview>
+  <title id='title9167'>Gnome Symbolic Icon Theme</title>

Same here, "GNOME-Chess Icon".

@@ +23,3 @@
+  <g inkscape:groupmode='layer' id='layer9' inkscape:label='apps' style='display:inline' transform='translate(-303.00022,104.99999)'>
+    
+    <path inkscape:connector-curvature='0' d='M 304.00606,-104.01562 304.0002,-90 l 0.006,0 0,0.0215 13.97266,0 0,-14.0371 z m 1.00391,1.00195 6.01757,0 0,5.98633 5.94727,0 0,6.04492 -5.97461,0 0,-6.01758 -5.99023,0 z' id='rect14955' sodipodi:nodetypes='cccccccccccccccc' style='color:#000000;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:medium;line-height:normal;font-family:sans-serif;text-indent:0;text-align:start;text-decoration:none;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:#000000;letter-spacing:normal;word-spacing:normal;text-transform:none;direction:ltr;block-progression:tb;writing-mode:lr-tb;baseline-shift:baseline;text-anchor:start;white-space:normal;clip-rule:nonzero;display:inline;overflow:visible;visibility:visible;opacity:1;isolation:auto;mix-blend-mode:normal;color-interpolation:sRGB;color-interpolation-filters:linearRGB;solid-color:#000000;solid-opacity:1;fill:#bebebe;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:1.0023694;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;paint-order:normal;color-rendering:auto;image-rendering:auto;shape-rendering:auto;text-rendering:auto;enable-background:accumulate'/>

Same here, pretty long line.
Comment 3 Arnaud B. 2015-03-30 14:07:15 UTC
Mh, interesting idea, but I’m not sure it completely hits its goal:
* first, because of a potential conflict with Lightsoff;
* secondly, because alternated-color board is even more I think associated with draughts/checkers than with chess.

Maybe a King/Queen piece could be used in its standard representation? (the one of the Simple theme, for example, with the problem of the a little inclined perspective view…) The first one would be really distinctive (it’s the piece which make you lose if it’s captured), I’m just not sure how the cross on the crown is perceived worldwide.
Comment 4 Michael Catanzaro 2015-03-30 15:17:17 UTC
I don't care about line length in an SVG icon :p

(In reply to Arnaud Bonatti from comment #3)
> Mh, interesting idea, but I’m not sure it completely hits its goal:
> * first, because of a potential conflict with Lightsoff;
> * secondly, because alternated-color board is even more I think associated
> with draughts/checkers than with chess.

Yes, the icon is not very good, but it's the same as the existing high contrast icon, just in the new style. Let's only reject his patch if it's worse than what we have now (like the four-in-a-row patch that shows the impossible board position, after you already fixed the old icon). Since you don't see any other problems, I think we can commit this.

> Maybe a King/Queen piece could be used in its standard representation? (the
> one of the Simple theme, for example, with the problem of the a little
> inclined perspective view…) The first one would be really distinctive (it’s
> the piece which make you lose if it’s captured), I’m just not sure how the
> cross on the crown is perceived worldwide.

I agree this would be much better, but Jakub has dozens of icons to take care of, so if we want a brand new one that's really a matter for a different bug.
Comment 5 Arnaud B. 2015-03-30 15:54:46 UTC
> Yes, the icon is not very good, but it's the same as the existing high contrast icon, just in the new style.

Arg. Right. Didn’t remember Chess had one (I don’t have it installed).

> Since you don't see any other problems, I think we can commit this.

There’s another thing I’m quite not happy with. The HighContrast icon has the dark tile in the bottom-left corner, as a chessboard. With this symbolic conversion, the non-white tile is in the top-left one.

> I agree this would be much better, but Jakub has dozens of icons to take care of

Yeps, I know. Many thanks for taking all this time for doing them, this icons are a real improvement. =)
Comment 6 Jakub Steiner 2015-03-31 18:12:39 UTC
Personally I'd go for a knight/horse head, but since the fullcolor variant uses a pawn and rook, pawn would probably work well. As Michael mentioned I didn't want to change metaphors as there's a lot to convert. Feel free to open a bug/request I'll sort it out asap.
Comment 7 Arnaud B. 2015-04-01 07:15:53 UTC
A single pawn would not be distinctive enough I think, it would evoke many race games. Knight has a similar problem in France/Belgium only, as our version of Pachisi/Parcheesi/Ludo is called “Petits chevaux”[1] (“Little Horses”) and is played with such pieces. Yay, France.

[1] https://en.wikipedia.org/wiki/Jeu_des_petits_chevaux
Comment 8 Michael Catanzaro 2015-04-01 12:59:45 UTC
I don't see why a pawn would evoke race games? If I saw a pawn I would think "chess." But a knight would be a more typical/preferred choice for the icon.

Anyway, a fancy new icon is one matter. I've filed bug #747173 for that. For this icon we have here in this bug now, I think we just want the color on each square switched before we push it, correct Arnaud? So that we have Black/White

WB
BW

And not:

BW
WB

(I'm presuming this change is very easy to make.)
Comment 9 Arnaud B. 2015-04-02 15:23:39 UTC
Moving the discussion of the best icon on the correct bug.

Yeps, switching colors is needed to maintain the current metaphor.
Comment 10 Jakub Steiner 2015-04-30 15:31:33 UTC
Created attachment 302670 [details] [review]
icon: provice a symbolic variant of the app icon

since 3.16 used for the recolorable high contrast theme
Comment 11 Michael Catanzaro 2015-04-30 15:55:24 UTC
OK this one is trippy. The solid squares (upper left, lower right in the most recent patch) get recolored to white. And the transparent squares remain black. So that explains why the colors became "flipped" during the conversion from high contrast to symbolic icon, and it matches Arnaud's request, but it's also completely context-dependent whether it's right.

Oh well, it's the best we can do with the current icon. :D Thanks!
Comment 12 Michael Catanzaro 2015-04-30 15:55:33 UTC
Attachment 302670 [details] pushed as 3b54bf4 - icon: provice a symbolic variant of the app icon