After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747021 - provide a scalable -symbolic variant of the app icon
provide a scalable -symbolic variant of the app icon
Status: RESOLVED FIXED
Product: four-in-a-row
Classification: Applications
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: four-in-a-row-maint
four-in-a-row-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-30 12:08 UTC by Jakub Steiner
Modified: 2015-04-30 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
icon: provide a symbolic variant of the app icon (16.76 KB, patch)
2015-03-30 12:09 UTC, Jakub Steiner
none Details | Review
icon: provide a symbolic variant of the app icon (18.00 KB, patch)
2015-03-30 13:46 UTC, Jakub Steiner
none Details | Review
Screenshot. (687.66 KB, image/png)
2015-03-30 14:25 UTC, Arnaud B.
  Details
icon: provide a symbolic variant of the app icon (18.01 KB, patch)
2015-04-30 15:29 UTC, Jakub Steiner
committed Details | Review

Description Jakub Steiner 2015-03-30 12:08:52 UTC
Starting with GNOME 3.16 we streamlined how high contrast icons are managed. The attached patch includes a symbolic variant of the app icon that is used for HC theme and recolorable at runtime.

See https://wiki.gnome.org/Initiatives/GnomeGoals/HighContrastAppIcons for more details.
Comment 1 Jakub Steiner 2015-03-30 12:09:18 UTC
Created attachment 300583 [details] [review]
icon: provide a symbolic variant of the app icon

since gnome 3.16 we're perusing the symbolic icon
for high contrast theme
Comment 2 Arnaud B. 2015-03-30 12:42:34 UTC
Three problems:
* As <circle> is used, the icon do not work as a symbolic one (not highlighted in the topbar). Circles should probably be transformed in a path, as I did for Iagno’s symbolic icon.
* I find the dark color hard to read in the topbar. That’s the reason why, for Iagno, I continue to use the “white border” thing (but I probably do a bad thing letting one circle empty, even if there are not case where that could be seen for now; but that’s another story).
* The circle in the bottom of the second column should be dark, or the drawn position is not playable.
Comment 3 Michael Catanzaro 2015-03-30 13:05:22 UTC
Review of attachment 300583 [details] [review]:

Changing patch status to reflect Arnaud's review. Thanks Jakub!
Comment 4 Jakub Steiner 2015-03-30 13:46:02 UTC
Created attachment 300592 [details] [review]
icon: provide a symbolic variant of the app icon

since gnome 3.16 we're perusing the symbolic icon
for high contrast theme
Comment 5 Arnaud B. 2015-03-30 14:25:26 UTC
Created attachment 300596 [details]
Screenshot.

The updated patch solves the first issue (the technical one).
Comment 6 Michael Catanzaro 2015-03-30 15:41:35 UTC
Review of attachment 300592 [details] [review]:

To be clear about what Arnaud was requesting: this patch reintroduces bug #677638, where there are two different lines of four circles of the same color in a row, which is not a possible game position. You can avoid that by swapping the color for one of the circles, preferably the second circle from the left in the bottom row, to match the highcolor icon.
Comment 7 Jakub Steiner 2015-04-30 15:29:21 UTC
Created attachment 302665 [details] [review]
icon: provide a symbolic variant of the app icon

since gnome 3.16 we're perusing the symbolic icon
for high contrast theme
Comment 8 Michael Catanzaro 2015-04-30 15:50:51 UTC
Super, thanks!

Attachment 302665 [details] pushed as 5626fda - icon: provide a symbolic variant of the app icon