GNOME Bugzilla – Bug 747012
provide a scalable -symbolic variant of the app icon
Last modified: 2018-01-26 02:05:40 UTC
Starting with GNOME 3.16 we streamlined how high contrast icons are managed. The attached patch includes a symbolic variant of the app icon that is used for HC theme and recolorable at runtime. See https://wiki.gnome.org/Initiatives/GnomeGoals/HighContrastAppIcons for more details.
Created attachment 300575 [details] [review] icon: provide a symbolic variant of the app icon Since 3.16 we are providing a symbolic variant of the app icon for covering the High Contrast theme use case. Cleaned up the naming to make it clear the source SVG is not actually being installed anywhere.
Thanks!, pushed as d046440a517b33ff18a7bde309e7cf8be9d9d18d - then 6588b6b8576bbe2c355bd033ac1412453e4467f4 because on my previous commit I forgot the renaming
Created attachment 300834 [details] [review] icon: provide a symbolic variant of the app icon Since 3.16 we are providing a symbolic variant of the app icon for covering the High Contrast theme use case. Cleaned up the naming to make it clear the source SVG is not actually being installed anywhere. The symbolic size has been introduced to hicolor to cope with the nominal size of 16x16 rather than the backward compatible 128x128.
Hey Pierre-Yves, could we get this symbolic icon added as well ?
What's up with this, did you change the icon? Or just trying to move it from hicolor/apps/scalable to hicolor/apps/symbolic?
I think it was just the sizing issue (scalable->symbolic)
We have tons of symbolic app icons installed under scalable; surely it doesn't matter where it gets installed? If it really matters, then we need to fix about 20 other apps. Anyway, it's obviously fine to move icons from scalable to symbolic. But your patch here doesn't apply on master since your original patch was pushed.
I don't recall the nitty gritty details, but the reason why for app icons you need to install to symbolic *size* is that hicolor has a nominal size of 128 rather than 16. So while for Adwaita we install symbolics to scalable, for hicolor we need to install to symbolic.
(In reply to Jakub Steiner from comment #8) > I don't recall the nitty gritty details, but the reason why for app icons > you need to install to symbolic *size* is that hicolor has a nominal size of > 128 rather than 16. So while for Adwaita we install symbolics to scalable, > for hicolor we need to install to symbolic. Thanks for the explanation. I tried your patch but it doesn't apply anymore. If would please update it and resubmitted, I'd glad to push it to master. Thanks.
I'm afraid I'm not familiar with meson yet to do a quick fix.