After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746957 - validate:launcher: Show timeout seconds for timeout result message
validate:launcher: Show timeout seconds for timeout result message
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
git master
Other Linux
: Normal normal
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-29 02:26 UTC by Young Han Lee
Modified: 2015-06-24 14:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Show timeout seconds for timeout result message (3.48 KB, patch)
2015-03-29 02:27 UTC, Young Han Lee
reviewed Details | Review

Description Young Han Lee 2015-03-29 02:26:28 UTC
Current timeout message doesn't show how many seconds a test took and it is timeouted by normal timeout or hard timeout like following.

1. normal timeout
validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out)
   
2. hard timeout
validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out)

Note that Test::process_update sets specific error message for hard_timeout case, but it is over written by Test::check_results.
Comment 1 Young Han Lee 2015-03-29 02:27:34 UTC
Created attachment 300530 [details] [review]
Show timeout seconds for timeout result message

This patch changes the message like following.
    
1. normal timeout
old : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out)
new : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out: 120 secs)
    
2. hard timeout
old : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out)
new : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Hard timeout reached: 600 secs)
Comment 2 Young Han Lee 2015-03-30 11:30:08 UTC
Thibault, would you review this as well?
Comment 3 Thibault Saunier 2015-03-30 11:37:48 UTC
Review of attachment 300530 [details] [review]:

I can not find where it set "(Hard timeout reached" ?

Otherwize looks good.
Comment 4 Young Han Lee 2015-03-30 11:46:42 UTC
The existing code already has it. Please refer to the following link.

http://phabricator.freedesktop.org/diffusion/GSTDEV/browse/master/validate/launcher/baseclasses.py;4c7ec6b8b13a7c1ec1f8c4e8a9ddab887c1e54aa$242

But, for now, the message is being overwritten by Test::check_results.
Comment 5 Thibault Saunier 2015-03-30 12:19:21 UTC
commit 4725f4ec099cace11b680ca7ca916362a4ad14c0
Author: Young Han Lee <y.lee@lge.com>
Date:   Sun Mar 29 11:13:01 2015 +0900

    validate:launcher: Show timeout seconds for timeout result message
    
    Current timeout message doesn't show how many seconds a test took and
    it is timeouted by normal timeout or hard timeout.
    
    This patch changes the message like following.
    
    1. normal timeout
    old : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out)
    new : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out: 120 secs)
    
    2. hard timeout
    old : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Application timed out)
    new : validate.http.playback.reverse_playback.raw_video_mov: Timeout (Hard timeout reached: 600 secs)
    
    https://bugzilla.gnome.org/show_bug.cgi?id=746957
(In reply to Young Han Lee from comment #4)
> The existing code already has it. Please refer to the following link.
> 
> http://phabricator.freedesktop.org/diffusion/GSTDEV/browse/master/validate/
> launcher/baseclasses.py;4c7ec6b8b13a7c1ec1f8c4e8a9ddab887c1e54aa$242
> 
> But, for now, the message is being overwritten by Test::check_results.

Got it, thanks.
Comment 6 Young Han Lee 2015-03-30 14:19:24 UTC
Thanks for your review!