After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745122 - gst-uninstalled: add adaptivedemux paths from -bad
gst-uninstalled: add adaptivedemux paths from -bad
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Mac OS
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-02-24 21:01 UTC by Matthieu Bouron
Modified: 2015-02-25 11:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gst-uninstalled: add adaptivedemux paths from -bad (1003 bytes, patch)
2015-02-24 21:03 UTC, Matthieu Bouron
committed Details | Review

Description Matthieu Bouron 2015-02-24 21:01:56 UTC
The following patch adds the adaptivedemux paths from -bad to the gst-uninstalled script.
Comment 1 Matthieu Bouron 2015-02-24 21:03:57 UTC
Created attachment 297826 [details] [review]
gst-uninstalled: add adaptivedemux paths from -bad
Comment 2 Thiago Sousa Santos 2015-02-24 21:33:23 UTC
Any build failure caused by missing this?
adaptivedemux isn't supposed to be public API and AFAIK the makefiles in -bad correctly build at the moment.

Are you planning on using it outside of gst-plugins-bad?
Comment 3 Tim-Philipp Müller 2015-02-24 23:18:42 UTC
It seems fine to me, I don't think it makes the API public in any way. I think theoretically it shouldn't be needed seeing that we specify the path to the .la in the elements, but I suspect it might help libtool / the dynamic linker to find the right lib.
Comment 4 Matthieu Bouron 2015-02-25 07:49:00 UTC
(In reply to Thiago Sousa Santos from comment #2)
> Any build failure caused by missing this?
> adaptivedemux isn't supposed to be public API and AFAIK the makefiles in
> -bad correctly build at the moment.
> 
> Are you planning on using it outside of gst-plugins-bad?

Nope but it fixes the following runtime errors (at least on osx):

(gst-plugin-scanner:18285): GStreamer-WARNING **: Failed to load plugin '/Users/mateo/gst/master/gst-plugins-bad/ext/dash/.libs/libgstdashdemux.so': dlopen(/Users/mateo/gst/master/gst-plugins-bad/ext/dash/.libs/libgstdashdemux.so, 2): Library not loaded: /usr/local/lib/libgstadaptivedemux-1.0.0.dylib
  Referenced from: /Users/mateo/gst/master/gst-plugins-bad/ext/dash/.libs/libgstdashdemux.so
  Reason: image not found

(gst-plugin-scanner:18285): GStreamer-WARNING **: Failed to load plugin '/Users/mateo/gst/master/gst-plugins-bad/ext/hls/.libs/libgstfragmented.so': dlopen(/Users/mateo/gst/master/gst-plugins-bad/ext/hls/.libs/libgstfragmented.so, 2): Library not loaded: /usr/local/lib/libgstadaptivedemux-1.0.0.dylib
  Referenced from: /Users/mateo/gst/master/gst-plugins-bad/ext/hls/.libs/libgstfragmented.so
  Reason: image not found

(gst-plugin-scanner:18285): GStreamer-WARNING **: Failed to load plugin '/Users/mateo/gst/master/gst-plugins-bad/ext/smoothstreaming/.libs/libgstsmoothstreaming.so': dlopen(/Users/mateo/gst/master/gst-plugins-bad/ext/smoothstreaming/.libs/libgstsmoothstreaming.so, 2): Library not loaded: /usr/local/lib/libgstadaptivedemux-1.0.0.dylib
  Referenced from: /Users/mateo/gst/master/gst-plugins-bad/ext/smoothstreaming/.libs/libgstsmoothstreaming.so
  Reason: image not found
Comment 5 Tim-Philipp Müller 2015-02-25 11:31:04 UTC
Thanks, pushed:

commit 62de2e762131177995d312177344a666c663d0ac
Author: Matthieu Bouron <matthieu.bouron@collabora.com>
Date:   Tue Feb 24 21:58:00 2015 +0100

    gst-uninstalled: add adaptivedemux paths from -bad
    
    https://bugzilla.gnome.org/show_bug.cgi?id=745122