After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 742662 - No zoom
No zoom
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.14.x
Other All
: Normal enhancement
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on: 783587
Blocks:
 
 
Reported: 2015-01-09 18:20 UTC by Adam Williamson
Modified: 2017-06-18 12:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
image-view: Support scrolling and zooming (18.79 KB, patch)
2017-04-12 06:52 UTC, Debarshi Ray
none Details | Review
application, help-overlay, preview-view: Hook up zooming to GActions (8.36 KB, patch)
2017-04-12 06:52 UTC, Debarshi Ray
none Details | Review
image-view: Support scrolling and zooming (22.46 KB, patch)
2017-06-05 18:38 UTC, Debarshi Ray
committed Details | Review
Add PhotosImageViewHelper (6.39 KB, patch)
2017-06-05 18:38 UTC, Debarshi Ray
none Details | Review
Add EggAnimation (46.71 KB, patch)
2017-06-05 18:39 UTC, Debarshi Ray
none Details | Review
utils: Add convenience API for GtkScrolledWindow (3.47 KB, patch)
2017-06-05 18:39 UTC, Debarshi Ray
none Details | Review
application, help-overlay, preview-view: Hook up zooming to GActions (20.09 KB, patch)
2017-06-05 18:39 UTC, Debarshi Ray
committed Details | Review
Add PhotosZoomBar (15.33 KB, patch)
2017-06-05 18:39 UTC, Debarshi Ray
none Details | Review
preview-nav-buttons: Use PhotosZoomBar (5.56 KB, patch)
2017-06-05 18:40 UTC, Debarshi Ray
none Details | Review
image-view: Implement smooth zooming (9.99 KB, patch)
2017-06-05 18:40 UTC, Debarshi Ray
none Details | Review
application, help-overlay, preview-view: Hook up zooming to GActions (14.46 KB, patch)
2017-06-06 09:55 UTC, Debarshi Ray
committed Details | Review
application, preview-view: Tweak the zoom-in/out GActions for scrolling (5.64 KB, patch)
2017-06-10 16:23 UTC, Debarshi Ray
committed Details | Review
utils: Add convenience API for GtkScrolledWindow (3.47 KB, patch)
2017-06-10 16:23 UTC, Debarshi Ray
committed Details | Review
preview-view: Use scroll-events to zoom, mouse movements for panning (8.46 KB, patch)
2017-06-10 16:23 UTC, Debarshi Ray
none Details | Review
Add PhotosImageViewHelper (6.39 KB, patch)
2017-06-10 16:24 UTC, Debarshi Ray
committed Details | Review
Add PhotosZoomBar (15.80 KB, patch)
2017-06-10 16:25 UTC, Debarshi Ray
committed Details | Review
Add EggAnimation (46.71 KB, patch)
2017-06-10 16:25 UTC, Debarshi Ray
committed Details | Review
preview-nav-buttons: Use PhotosZoomBar (5.56 KB, patch)
2017-06-10 16:26 UTC, Debarshi Ray
committed Details | Review
image-view: Implement smooth zooming (10.32 KB, patch)
2017-06-10 16:26 UTC, Debarshi Ray
committed Details | Review
preview-view: Use scroll-events to zoom, mouse movements for panning (8.19 KB, patch)
2017-06-10 16:39 UTC, Debarshi Ray
committed Details | Review
preview-view: Silence -Wunused-label (938 bytes, patch)
2017-06-14 21:34 UTC, Debarshi Ray
committed Details | Review
preview-view: Don't propagate motion-notify events after handling them (1.08 KB, patch)
2017-06-18 12:38 UTC, Debarshi Ray
committed Details | Review
preview-nav-buttons: Handle touch events during the capture phase (2.21 KB, patch)
2017-06-18 12:38 UTC, Debarshi Ray
committed Details | Review
Add PhotosZoomControls (16.23 KB, patch)
2017-06-18 12:39 UTC, Debarshi Ray
committed Details | Review
preview-nav-buttons: Use PhotosZoomControls (5.59 KB, patch)
2017-06-18 12:39 UTC, Debarshi Ray
committed Details | Review
preview-nav-buttons, preview-view: Allow disabling navigation buttons (4.12 KB, patch)
2017-06-18 12:40 UTC, Debarshi Ray
committed Details | Review
preview-view: Disable the navigation buttons when zoomed in (1.69 KB, patch)
2017-06-18 12:40 UTC, Debarshi Ray
committed Details | Review
preview-nav-buttons, preview-view: Allow disabling auto-hiding (5.10 KB, patch)
2017-06-18 12:40 UTC, Debarshi Ray
committed Details | Review
preview-view: Don't auto-hide the zoom controls when zoomed in (1.90 KB, patch)
2017-06-18 12:41 UTC, Debarshi Ray
committed Details | Review
Add PhotosImageViewHelper (6.60 KB, patch)
2017-06-18 12:41 UTC, Debarshi Ray
committed Details | Review
Add EggAnimation (46.71 KB, patch)
2017-06-18 12:41 UTC, Debarshi Ray
committed Details | Review
image-view: Implement smooth zooming (10.32 KB, patch)
2017-06-18 12:42 UTC, Debarshi Ray
committed Details | Review

Description Adam Williamson 2015-01-09 18:20:20 UTC
As reported downstream at https://bugzilla.redhat.com/show_bug.cgi?id=924376 , it doesn't seem possible to zoom in or out of any picture in Photos. Seems a major missing feature. Still valid with 3.14 (Fedora 21).
Comment 1 Andreas Nilsson 2016-12-01 13:17:45 UTC
The mockups for file importing into Photos has zoom controllers.
I'm not sure if it's on the roadmap though.
https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/content-apps/open-files-with-content-apps.png
Comment 2 Debarshi Ray 2017-04-12 06:52:03 UTC
Created attachment 349702 [details] [review]
image-view: Support scrolling and zooming
Comment 3 Debarshi Ray 2017-04-12 06:52:20 UTC
Created attachment 349703 [details] [review]
application, help-overlay, preview-view: Hook up zooming to GActions
Comment 4 Debarshi Ray 2017-06-05 14:49:57 UTC
For those who might be following along, see the gnome-photos:wip/rishi/zoom for the latest version of the patches for this.
Comment 5 Debarshi Ray 2017-06-05 18:38:29 UTC
Created attachment 353211 [details] [review]
image-view: Support scrolling and zooming
Comment 6 Debarshi Ray 2017-06-05 18:38:54 UTC
Created attachment 353212 [details] [review]
Add PhotosImageViewHelper
Comment 7 Debarshi Ray 2017-06-05 18:39:08 UTC
Created attachment 353213 [details] [review]
Add EggAnimation
Comment 8 Debarshi Ray 2017-06-05 18:39:22 UTC
Created attachment 353214 [details] [review]
utils: Add convenience API for GtkScrolledWindow
Comment 9 Debarshi Ray 2017-06-05 18:39:39 UTC
Created attachment 353215 [details] [review]
application, help-overlay, preview-view: Hook up zooming to GActions
Comment 10 Debarshi Ray 2017-06-05 18:39:51 UTC
Created attachment 353216 [details] [review]
Add PhotosZoomBar
Comment 11 Debarshi Ray 2017-06-05 18:40:04 UTC
Created attachment 353217 [details] [review]
preview-nav-buttons: Use PhotosZoomBar
Comment 12 Debarshi Ray 2017-06-05 18:40:17 UTC
Created attachment 353218 [details] [review]
image-view: Implement smooth zooming
Comment 13 Debarshi Ray 2017-06-05 18:40:55 UTC
These are based on this mockup from Allan:
https://www.dropbox.com/s/i8ng0vuny580z27/zoom-controls.png?dl=0
Comment 14 Debarshi Ray 2017-06-06 09:55:00 UTC
Created attachment 353250 [details] [review]
application, help-overlay, preview-view: Hook up zooming to GActions
Comment 15 Debarshi Ray 2017-06-10 16:23:11 UTC
Created attachment 353530 [details] [review]
application, preview-view: Tweak the zoom-in/out GActions for scrolling
Comment 16 Debarshi Ray 2017-06-10 16:23:32 UTC
Created attachment 353531 [details] [review]
utils: Add convenience API for GtkScrolledWindow
Comment 17 Debarshi Ray 2017-06-10 16:23:52 UTC
Created attachment 353532 [details] [review]
preview-view: Use scroll-events to zoom, mouse movements for panning
Comment 18 Debarshi Ray 2017-06-10 16:24:56 UTC
Created attachment 353533 [details] [review]
Add PhotosImageViewHelper
Comment 19 Debarshi Ray 2017-06-10 16:25:12 UTC
Created attachment 353534 [details] [review]
Add PhotosZoomBar
Comment 20 Debarshi Ray 2017-06-10 16:25:46 UTC
Created attachment 353535 [details] [review]
Add EggAnimation
Comment 21 Debarshi Ray 2017-06-10 16:26:08 UTC
Created attachment 353536 [details] [review]
preview-nav-buttons: Use PhotosZoomBar
Comment 22 Debarshi Ray 2017-06-10 16:26:22 UTC
Created attachment 353537 [details] [review]
image-view: Implement smooth zooming
Comment 23 Debarshi Ray 2017-06-10 16:39:53 UTC
Created attachment 353539 [details] [review]
preview-view: Use scroll-events to zoom, mouse movements for panning
Comment 24 Debarshi Ray 2017-06-14 21:34:50 UTC
Created attachment 353780 [details] [review]
preview-view: Silence -Wunused-label
Comment 25 Debarshi Ray 2017-06-18 12:38:39 UTC
Created attachment 353980 [details] [review]
preview-view: Don't propagate motion-notify events after handling them
Comment 26 Debarshi Ray 2017-06-18 12:38:58 UTC
Created attachment 353981 [details] [review]
preview-nav-buttons: Handle touch events during the capture phase
Comment 27 Debarshi Ray 2017-06-18 12:39:18 UTC
Created attachment 353982 [details] [review]
Add PhotosZoomControls
Comment 28 Debarshi Ray 2017-06-18 12:39:38 UTC
Created attachment 353983 [details] [review]
preview-nav-buttons: Use PhotosZoomControls
Comment 29 Debarshi Ray 2017-06-18 12:40:01 UTC
Created attachment 353984 [details] [review]
preview-nav-buttons, preview-view: Allow disabling navigation buttons
Comment 30 Debarshi Ray 2017-06-18 12:40:24 UTC
Created attachment 353985 [details] [review]
preview-view: Disable the navigation buttons when zoomed in
Comment 31 Debarshi Ray 2017-06-18 12:40:46 UTC
Created attachment 353986 [details] [review]
preview-nav-buttons, preview-view: Allow disabling auto-hiding
Comment 32 Debarshi Ray 2017-06-18 12:41:04 UTC
Created attachment 353987 [details] [review]
preview-view: Don't auto-hide the zoom controls when zoomed in
Comment 33 Debarshi Ray 2017-06-18 12:41:28 UTC
Created attachment 353988 [details] [review]
Add PhotosImageViewHelper
Comment 34 Debarshi Ray 2017-06-18 12:41:44 UTC
Created attachment 353989 [details] [review]
Add EggAnimation
Comment 35 Debarshi Ray 2017-06-18 12:42:05 UTC
Created attachment 353990 [details] [review]
image-view: Implement smooth zooming
Comment 36 Debarshi Ray 2017-06-18 12:48:29 UTC
So that's the most of it. I have filed follow-up bugs for supporting gestures (bug 783922) and editing (bug 783924).