Bug 74197 – Control-T Control-D crashes profterm

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 74197 - Control-T Control-D crashes profterm


Summary:	Control-T Control-D crashes profterm


Status:	RESOLVED FIXED

Product:	libzvt
Classification:	Deprecated
Component:	general
Version:	unspecified
Hardware:	Other Linux

Importance:	Urgent critical
Target Milestone:	---
Assigned To:	jacob berkman
QA Contact:	Luis Villa

URL:
Whiteboard:

Duplicates:	74472 75280 75338 75489 76816 76839 (view as bug list)
Depends on:
Blocks:

Reported:	2002-03-11 03:48 UTC by Ryan Lovett
Modified:	2004-12-22 21:47 UTC

See Also:
GNOME target:	---
GNOME version:	2.0

Attachments
proposed patch (2.38 KB, patch) 2002-04-05 16:06 UTC, Ganesan	none	Details \| Review
fix (7.57 KB, patch) 2002-04-14 01:22 UTC, Havoc Pennington	none	Details \| Review

Description Ryan Lovett 2002-03-11 03:48:42 UTC

CVS today:
  Type Control-T
  Type Control-D
  <crash>

With ignoreeof unset, the above causes profterm to crash. ^T is set in
keybindings to create a new tab.


spacecoaster:~> gdb gnome-terminal
GNU gdb 5.1.1
Copyright 2002 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i386-linux"...
(gdb) r
Starting program: /home/ryan/bin/gnome-terminal 
[New Thread 1024 (LWP 3538)]
gnome-terminal 
gnome-terminal --window-with-profile-internal-id=Default --hide-menubar 
gnome-terminal --window-with-profile-internal-id=Default --hide-menubar
--tab-with-profile-internal-id=Default 

Program received signal SIGSEGV, Segmentation fault.

+ Trace 18958

Thread 1024 (LWP 3538)

#0 g_type_check_instance_cast
at gtype.c line 2603
#1 zvt_configure_window
at background.c line 782
#2 _gtk_marshal_BOOLEAN__BOXED
at gtkmarshalers.c line 82
#3 g_closure_invoke
at gclosure.c line 437
#4 signal_emit_unlocked_R
at gsignal.c line 2340
#5 g_signal_emit_valist
at gsignal.c line 2109
#6 gtk_signal_emit
at gtksignal.c line 355
#7 gtk_widget_event_internal
at gtkwidget.c line 3069
#8 gtk_widget_event
at gtkwidget.c line 2930
#9 gtk_main_do_event
at gtkmain.c line 1135
#10 gdk_event_dispatch
at gdkevents-x11.c line 1753
#11 g_main_dispatch
at gmain.c line 1616
#12 g_main_context_dispatch
at gmain.c line 2160
#13 g_main_context_iterate
at gmain.c line 2241
#14 g_main_loop_run
at gmain.c line 2461
#15 gtk_main
at gtkmain.c line 882
#16 main
at terminal.c line 762
#17 __libc_start_main
from /lib/libc.so.6

Comment 1 Havoc Pennington 2002-03-17 19:56:59 UTC

I think there are several dups of this against libzvt already.

Comment 2 Luis Villa 2002-03-30 19:11:46 UTC

Eck; lots of dups.

Comment 3 Luis Villa 2002-03-30 19:12:02 UTC

*** Bug 74472 has been marked as a duplicate of this bug. ***

Comment 4 Luis Villa 2002-03-30 19:12:22 UTC

*** Bug 75280 has been marked as a duplicate of this bug. ***

Comment 5 Luis Villa 2002-03-30 19:12:32 UTC

*** Bug 75338 has been marked as a duplicate of this bug. ***

Comment 6 Luis Villa 2002-03-30 19:12:44 UTC

*** Bug 75489 has been marked as a duplicate of this bug. ***

Comment 7 Luis Villa 2002-03-30 19:12:54 UTC

*** Bug 76816 has been marked as a duplicate of this bug. ***

Comment 8 Luis Villa 2002-03-30 19:13:04 UTC

*** Bug 76839 has been marked as a duplicate of this bug. ***

Comment 9 Senthilkumar Ramasamy 2002-04-05 15:17:18 UTC

Analysis:
zvt_configure_window() is getting ZvtTerm whose memory is 
freed already. This is causing the crash.

ZvtTerm (screen->priv->term) is freed in
terminal_window_remove_screen() if its ref count is 1, 

screen->priv->term 's ref count is reduced from 3 to 1 in
gtk_container_remove() . don't know how.

The callback function is called many no of times, this needs 
to be corrected.

Comment 10 Ganesan 2002-04-05 16:06:27 UTC

Created attachment 7574 [details] [review]
proposed patch

Comment 11 jacob berkman 2002-04-05 19:31:08 UTC

havoc, does the patch make sense to you?

Comment 12 Ganesan 2002-04-08 06:58:49 UTC

While closing a tab in the transparent background mode, the already
connected signal("configure_event") for the tab needs to be
disconnected, otherwise the crash will occur when trying to configure
the closed tab. In the above patch, when a tab is closed the
corresponding signal is disconnected.

Comment 13 Havoc Pennington 2002-04-14 01:22:51 UTC

Created attachment 7701 [details] [review]
fix

Comment 14 Havoc Pennington 2002-04-14 01:23:30 UTC

I'm putting in a more elaborate fix that also cleans up the 
code a bit.