After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741879 - audio/videotestsrc: Report latency in live-mode
audio/videotestsrc: Report latency in live-mode
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-12-22 21:06 UTC by Sebastian Dröge (slomo)
Modified: 2014-12-24 12:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
audiotestsrc: Report our latency properly in live mode (1.53 KB, patch)
2014-12-22 21:07 UTC, Sebastian Dröge (slomo) 		committed Details | Review
videotestsrc: Report our latency properly in live mode (1.56 KB, patch)
2014-12-22 21:07 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2014-12-22 21:06:40 UTC 
See attached patches. This makes the test sources behave more like real live sources.

Is there any problem with doing this?
Comment 1 Sebastian Dröge (slomo) 2014-12-22 21:07:26 UTC 
Created attachment 293201 [details] [review]
audiotestsrc: Report our latency properly in live mode

While we have no latency at all in theory, any other live source has the
duration of one buffer as minimum latency. Do the same in audiotestsrc.
Comment 2 Sebastian Dröge (slomo) 2014-12-22 21:07:32 UTC 
Created attachment 293202 [details] [review]
videotestsrc: Report our latency properly in live mode

While we have no latency at all in theory, any other live source has the
duration of one buffer as minimum latency. Do the same in videotestsrc.
Comment 3 Sebastian Dröge (slomo) 2014-12-24 12:00:13 UTC 
commit 8abfdd127fd60a5720b579f3bf3a573966d25a88
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Dec 22 22:04:41 2014 +0100

    videotestsrc: Report our latency properly in live mode
    
    While we have no latency at all in theory, any other live source has the
    duration of one buffer as minimum latency. Do the same in videotestsrc.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=741879

commit 631d356845e15e38142c9fe5a9158a46fdd5a3ed
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Dec 22 22:00:26 2014 +0100

    audiotestsrc: Report our latency properly in live mode
    
    While we have no latency at all in theory, any other live source has the
    duration of one buffer as minimum latency. Do the same in audiotestsrc.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=741879
Comment 4 Tim-Philipp Müller 2014-12-24 12:00:13 UTC 
I think this makes sense and would be expected behaviour anyway if someone sets live=true... If it breaks anything, that would be broken for live sources then, which people would probably want to know about if they select live=true.