GNOME Bugzilla – Bug 741097
oggdemux: Fix seeking before the first frame.
Last modified: 2014-12-05 15:09:22 UTC
The previous code was setting keytarget to target to make sure the keyframe found for each pad was indeed before the target. Then if target == keytarget, it assumed a keyframe had been found, which was not the case if target was before the first frame in the file. This patch checks that a keyframe was indeed found, and if not seeks to 0, without bisecting again. Assuming default gst qa assets in $HOME/gst-validate seek_before_first_frame.scenario: description, seek=true, handles-states=true pause, playback-time=0.0 seek, playback-time=0.0, start=0.0, flags=accurate+flush seek, playback-time=0.0, start=0.01, flags=accurate+flush seek, playback-time=0.0, start=0.1, flags=accurate+flush GST_DEBUG=*theoradec*:2 gst-validate-1.0 playbin \ uri=file://$HOME/gst-validate/gst-qa-assets/medias/ogg/vorbis_theora.0.ogg \ --set-scenario seek_before_first_frame.scenario
Created attachment 292112 [details] [review] oggdemux: Fix seeking before the first frame.
commit 4e228e0a1f2b01c79378a9d0ba56b58353a5a572 Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com> Date: Thu Nov 27 05:53:20 2014 +0100 oggdemux: Fix seeking before the first frame. The previous code was setting keytarget to target to make sure the keyframe found for each pad was indeed before the target. Then if target == keytarget, it assumed a keyframe had been found, which was not the case if target was before the first frame in the file. This patch checks that a keyframe was indeed found, and if not seeks to 0, without bisecting again. Assuming default gst qa assets in $HOME/gst-validate seek_before_first_frame.scenario: description, seek=true, handles-states=true pause, playback-time=0.0 seek, playback-time=0.0, start=0.0, flags=accurate+flush seek, playback-time=0.0, start=0.01, flags=accurate+flush seek, playback-time=0.0, start=0.1, flags=accurate+flush GST_DEBUG=*theoradec*:2 gst-validate-1.0 playbin \ uri=file://$HOME/gst-validate/gst-qa-assets/medias/ogg/vorbis_theora.0.ogg \ --set-scenario seek_before_first_frame.scenario https://bugzilla.gnome.org/show_bug.cgi?id=741097
Review of attachment 292112 [details] [review]: commited