GNOME Bugzilla – Bug 74057
profile editor should pop up a warning if two profiles would have the same name
Last modified: 2005-07-01 23:39:02 UTC
Reproducibility: Always Procedure: 1. Start up the gnome terminal and select 'Edit: Profiles... ' option from the main menu bar. The 'Manage terminal profiles' dialog box comes up. 2. Click on the 'New...' button. The 'New terminal profile' dialog box comes up. Type any name for a profile and clock on the 'Create button. The new profile gets created. 3. Repeat steps 1 and 2 and try to create another profile with the same name. An error message comes up saying that that profile already exists. Repeat steps 1 and 2 and create a profile with a different name. 4.Switch to the profile created by selecting it from the list under 'Terminal: Profile'. Then select 'Edit: Current profile...' option. The 'Editing profile' dialog box comes up. 5.In the 'General' tab replace the name in the 'Profile name' text box with the name of an existing profile. Replace the name from the 'Initial title' text box in the 'Title and Command' tab with the name same name of an existing profile.Close the dialog box. 6.Select'Terminal: Profile' option to see the list of the existing profiles. There exists two profiles with the same name. How can two profiles have the same name? This testing has been done on the recent build of Gnome 2.0 done on 09/03/2002. Version of Gnome terminal is 1.91
I don't think this is a big deal; it's quite hard to validate and introduces thorny questions about how to type in the name "foobar" if you have a profile named "foo" gnome-terminal won't break if you have duplicate names, and users will know how to fix it if they have duplicate names. So I think it's best to just avoid the code/UI complexity and let you name things the same if you want.
Is not this very weird? If this is not a big deal and if it is assumed that the user can fix theproblem of having duplicate names then why does the error message comes when we are trying to create a new profile with a name that already exists? One should be able to create profiles with duplicate name also then. Otherwise everything becomes inconsistent.
Yeah that's a bit strange. We could change the dialog to be "are you sure you want two profiles with the same name?" maybe. But I don't think it matters very much.
I think it matters to a user specially when there is an error message coming up while trying to create a profile with the same name. I think this incinsistency should be removed. Or else the error message should be reframed as you said, Havoc. I would prefer to close the bug only after the inconsistency is removed.
I'm retitling to make this a little easier to understand/find, and correcting the severity. Since the feature /works/ even if it is a bit confusing, it is not major.
Created attachment 35044 [details] [review] Proposed patch Proposed patch to ask the user's option before creating a new profile with the same name as an existing profile.
Should go in when the freezes lift again. Too late for 2.10.0 I guess.
Commited to HEAD.