After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 73900 - lot of warnings when compiling with forte 6.2 on solaris
lot of warnings when compiling with forte 6.2 on solaris
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
1.3.x
Other Solaris
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2002-03-07 21:13 UTC by Erwann Chenede
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (56.28 KB, patch)
2002-03-07 21:17 UTC, Erwann Chenede
none Details | Review
Portion of patch that was applied (19.27 KB, patch)
2002-03-20 21:46 UTC, Owen Taylor
none Details | Review

Description Erwann Chenede 2002-03-07 21:13:17 UTC
please find attached to remove these warnings.
Is it Ok to commit ?
Comment 1 Erwann Chenede 2002-03-07 21:17:24 UTC
Created attachment 7039 [details] [review]
proposed patch
Comment 2 Erwann Chenede 2002-03-07 21:19:21 UTC
note that I just added a FIXME in gdkevents.c as I didn't know
how to translate a GdkVisibilityState in a GdkModifierType.
Comment 3 Owen Taylor 2002-03-20 21:45:44 UTC
I've applied about half  of this patch (will attach patch as 
applied.) I omitted the portions of your patch that were
fixing implicit casts between signed and unsigned because:

 - I believe that these casts detract from the clarity of the
   code.
 - These casts can hide real problems that GCC would otherwise
   warn about. (E.g., change of constness)
 - In my experience, these signed/unsigned conversions are 
   almost never real problems.

I apologize for the inconvenience of still having a lot of
warnings with Forte.

Wed Mar 20 16:36:08 2002  Owen Taylor  <otaylor@redhat.com>

        * gtk/*.c: Patch from Erwann Chenede, #73900 fixing
	a lot of warnings with Forte CC, mostly implicit
	casts between void * and function pointers.
	
	* gdk/gdkevents.c (gdk_event_get_state): GdkEventVisibility's
	state field is not a GdkModifierType. (Also #73900)

Please note that 'const gpointer' is _not_ the same as
'const void *', but rather means 'void * const'; this
is why 'gconstpointer' exists. 

Comment 4 Owen Taylor 2002-03-20 21:46:13 UTC
Created attachment 7274 [details] [review]
Portion of patch that was applied