GNOME Bugzilla – Bug 73900
lot of warnings when compiling with forte 6.2 on solaris
Last modified: 2004-12-22 21:47:04 UTC
please find attached to remove these warnings. Is it Ok to commit ?
Created attachment 7039 [details] [review] proposed patch
note that I just added a FIXME in gdkevents.c as I didn't know how to translate a GdkVisibilityState in a GdkModifierType.
I've applied about half of this patch (will attach patch as applied.) I omitted the portions of your patch that were fixing implicit casts between signed and unsigned because: - I believe that these casts detract from the clarity of the code. - These casts can hide real problems that GCC would otherwise warn about. (E.g., change of constness) - In my experience, these signed/unsigned conversions are almost never real problems. I apologize for the inconvenience of still having a lot of warnings with Forte. Wed Mar 20 16:36:08 2002 Owen Taylor <otaylor@redhat.com> * gtk/*.c: Patch from Erwann Chenede, #73900 fixing a lot of warnings with Forte CC, mostly implicit casts between void * and function pointers. * gdk/gdkevents.c (gdk_event_get_state): GdkEventVisibility's state field is not a GdkModifierType. (Also #73900) Please note that 'const gpointer' is _not_ the same as 'const void *', but rather means 'void * const'; this is why 'gconstpointer' exists.
Created attachment 7274 [details] [review] Portion of patch that was applied