GNOME Bugzilla – Bug 737219
flacparse: When generating headers, leave total_samples at 0 if upstream duration query returns GST_CLOCK_TIME_NONE.
Last modified: 2014-09-24 13:44:41 UTC
The current implementation converts GST_CLOCK_TIME_NONE to a duration in samples, in my case about 248M. This causes libFLAC to (silently) stop decoding when this value is reached. If the duration is NONE, the total_samples should be 0 so that the stream doesn't end prematurely.
Created attachment 286939 [details] [review] Proposed fix
I just fixed that earlier today. Please let me know if something is still missing commit 91a3d044f08ce612594ca638ce6ded1b3bb85f28 Author: Sebastian Dröge <sebastian@centricular.com> Date: Tue Sep 23 22:55:48 2014 +0300 flacparse: Only calculate with durations != -1
I pulled that patch on top of my 1.4.1, it resolves the issues I was having. Thanks!