After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737219 - flacparse: When generating headers, leave total_samples at 0 if upstream duration query returns GST_CLOCK_TIME_NONE.
flacparse: When generating headers, leave total_samples at 0 if upstream dur...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.4.1
Other Linux
: Normal normal
: 1.4.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-23 21:37 UTC by Jason Litzinger
Modified: 2014-09-24 13:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix (1.88 KB, patch)
2014-09-23 21:37 UTC, Jason Litzinger 		committed Details | Review

Description Jason Litzinger 2014-09-23 21:37:03 UTC 
The current implementation converts GST_CLOCK_TIME_NONE to a duration in samples, in my case about 248M.  This causes libFLAC to (silently) stop decoding when this value is reached.  If the duration is NONE, the total_samples should be 0 so that the stream doesn't end prematurely.
Comment 1 Jason Litzinger 2014-09-23 21:37:41 UTC 
Created attachment 286939 [details] [review]
Proposed fix
Comment 2 Sebastian Dröge (slomo) 2014-09-23 21:49:39 UTC 
I just fixed that earlier today. Please let me know if something is still missing

commit 91a3d044f08ce612594ca638ce6ded1b3bb85f28
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Tue Sep 23 22:55:48 2014 +0300

    flacparse: Only calculate with durations != -1
Comment 3 Jason Litzinger 2014-09-24 13:44:41 UTC 
I pulled that patch on top of my 1.4.1, it resolves the issues I was having.  Thanks!