After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736892 - rtpmanager: Removed unwanted variable and assignment
rtpmanager: Removed unwanted variable and assignment
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal minor
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-18 12:23 UTC by Sanjay NM
Modified: 2014-09-24 00:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtpmanager: Removed unwanted variable and assignment (861 bytes, patch)
2014-09-18 12:23 UTC, Sanjay NM 		needs-work Details | Review

Description Sanjay NM 2014-09-18 12:23:13 UTC 
Created attachment 286486 [details] [review]
rtpmanager: Removed unwanted variable and assignment

Removed unwanted variable and assignment
Comment 1 Tim-Philipp Müller 2014-09-23 23:36:57 UTC 
Comment on attachment 286486 [details] [review]
rtpmanager: Removed unwanted variable and assignment

The problem here is the ret=FALSE assignment which is overwritten again later by ret=klass->foo without having been used in the  mean time.

I think

  ret = klass->foo();
  return ret;

is not a bad pattern stylistically, don't see why the variable can't stay.