GNOME Bugzilla – Bug 736551
No Favorites Found
Last modified: 2015-01-06 18:35:16 UTC
When you don't have any favorites, the favorites view shows a message: "No Favorites Found" It's a bit negative, and isn't very helpful - it doesn't provide a clue about how to add favorites. Maybe something like this would be better? "Starred photos will appear here" You could use a star icon instead of the photo mimetype one, too.
Created attachment 288337 [details] [review] Changed text and image for empty result box in "Favorite View" * "No Favorites Found" is now "Starred photos will appear here" * Changed icon to "starred-symbolic" Fixes:
Created attachment 292530 [details] Screenshot
Review of attachment 288337 [details] [review]: Looks good to me. I would tweak the commit message a bit, though. eg., it is preferable to start it with "Change" instead of "Changed".
Created attachment 292552 [details] [review] empty-results-box: Change text and icon for favorites Tweaked the commit message. Please commit after running it past Allan.
(In reply to comment #2) > Created an attachment (id=292530) [details] > Screenshot The screenshot looks good, and is an improvement. I was hoping that Andreas's initial states designs [1, 2] would reach a state where we could use them as a template for the layout here. Unfortunately, they haven't progressed all that much, although I do plan to make sure that the work keeps moving. That leaves us with two options - land this patch now, and revisit in the future if necessary, or wait for the initial states designs to mature. I'd be happy with either. [1] https://wiki.gnome.org/Design/Whiteboards/InitialStates [2] https://wiki.gnome.org/Design/Whiteboards/InitialStates?action=AttachFile&do=view&target=layout-proposal.png
(In reply to comment #5) > (In reply to comment #2) > > Created an attachment (id=292530) [details] [details] > > Screenshot > > The screenshot looks good, and is an improvement. Thanks for staying on top of this, Allan. > I was hoping that Andreas's initial states designs [1, 2] would reach a state > where we could use them as a template for the layout here. Unfortunately, they > haven't progressed all that much, although I do plan to make sure that the work > keeps moving. > > That leaves us with two options - land this patch now, and revisit in the > future if necessary, or wait for the initial states designs to mature. I'd be > happy with either. Let's land it. If Andreas doesn't get time to work on them before 3.16, we will at least have this improvement.