After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734476 - navseek: Unref peer pad after usage
navseek: Unref peer pad after usage
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 1.4.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-08 10:45 UTC by Sebastian Rasmussen
Modified: 2014-08-08 19:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch aiming to fix leak. (707 bytes, patch)
2014-08-08 10:46 UTC, Sebastian Rasmussen
committed Details | Review

Description Sebastian Rasmussen 2014-08-08 10:45:41 UTC
gst_pad_get_peer() returns a reference to a pad, this reference must be unreffed after usage or else it will be leaked. The attach patch plugs the leak.
Comment 1 Sebastian Rasmussen 2014-08-08 10:46:34 UTC
Created attachment 282896 [details] [review]
Proposed patch aiming to fix leak.
Comment 2 Thiago Sousa Santos 2014-08-08 19:21:47 UTC
master:
commit edf87280160af3db4471899b4b1a7da25b873d5a
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Fri Aug 8 12:44:09 2014 +0200

    navseek: Unref peer pad after usage
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=734476


1.4:
commit fbf5d4687fceb097dfed00d9d84406393ca2fac5
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Fri Aug 8 12:44:09 2014 +0200

    navseek: Unref peer pad after usage
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=734476