After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731391 - sluggish next/previous buttons
sluggish next/previous buttons
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-06-09 07:57 UTC by Allan Day
Modified: 2015-01-23 15:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
base-item: Port the load operation to GTask (3.69 KB, patch)
2014-07-30 10:34 UTC, Debarshi Ray
committed Details | Review
base-item: Yield after each iteration of the processor (1.26 KB, patch)
2014-07-30 10:35 UTC, Debarshi Ray
none Details | Review
base-item: Lower the priority of the loading thread (869 bytes, patch)
2014-07-30 10:35 UTC, Debarshi Ray
none Details | Review

Description Allan Day 2014-06-09 07:57:21 UTC
When I press the floating next/previous buttons, they feel extremely sluggish - the button is slow to reach the pushed state, and slow to return to its original raised appearance after I release the mouse button.

This occurs with even a small photo collection (I currently only have 4 screenshots in ~/Pictures).

The next and previous buttons should be responsive, like any other button.
Comment 1 prasad mhatre 2014-07-08 14:13:04 UTC
can we use arrow keys to navigate.And the moreover,we can add a small '^'button at down center position,and when the mouse over event occurs ,it will slide up the control buttons in upward direction on which there will the the prev/next button would be present through it will can navigate the photos rather than having floating prev/next buttons.
Comment 2 Debarshi Ray 2014-07-08 15:42:37 UTC
(In reply to comment #1)
> can we use arrow keys to navigate.

We already can. See bug 726685
Comment 3 Pranav Kant 2014-07-28 10:21:34 UTC
May be duplicate of Bug 733213 ?
Comment 4 Debarshi Ray 2014-07-30 10:34:46 UTC
Created attachment 282008 [details] [review]
base-item: Port the load operation to GTask

This one doesn't actually fix anything.
Comment 5 Debarshi Ray 2014-07-30 10:35:11 UTC
Created attachment 282009 [details] [review]
base-item: Yield after each iteration of the processor
Comment 6 Debarshi Ray 2014-07-30 10:35:36 UTC
Created attachment 282010 [details] [review]
base-item: Lower the priority of the loading thread
Comment 7 Debarshi Ray 2014-07-30 10:36:11 UTC
(In reply to comment #3)
> May be duplicate of Bug 733213 ?

Definitely related, but there might be some slight differences. Let's keep them separate for the moment.
Comment 8 Debarshi Ray 2015-01-23 13:57:56 UTC
Can you please try gnome-photos Git master. The following commit should speed things up. It would be even better if you could test it with the Git masters of babl and gegl. Please edit gnome-photos/configure.ac to use gegl-0.3 if you do that.

commit 04d201fff34fe37d27c22583be37ff558bb91f2d
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Fri Jan 23 12:40:41 2015 +0100

    gegl-gtk-view-helper: Optimize blitting
    
    Use Babl's cairo-ARGB32 format. It has some optimizations and is
    noticeably faster than the equivalent B'aG'aR'aA u8.
    
    From gegl-gtk commit 3d28897caf9ee0bd091ea93df5a2a00fe4355302
Comment 9 Pranav Kant 2015-01-23 14:02:28 UTC
(In reply to comment #8)
> Can you please try gnome-photos Git master. The following commit should speed
> things up. It would be even better if you could test it with the Git masters of
> babl and gegl. Please edit gnome-photos/configure.ac to use gegl-0.3 if you do
> that.
> 
> commit 04d201fff34fe37d27c22583be37ff558bb91f2d
> Author: Debarshi Ray <debarshir@gnome.org>
> Date:   Fri Jan 23 12:40:41 2015 +0100
> 
>     gegl-gtk-view-helper: Optimize blitting
> 
>     Use Babl's cairo-ARGB32 format. It has some optimizations and is
>     noticeably faster than the equivalent B'aG'aR'aA u8.
> 
>     From gegl-gtk commit 3d28897caf9ee0bd091ea93df5a2a00fe4355302

Works for me. Significant improvement in photos navigation after this commit.
Comment 10 Debarshi Ray 2015-01-23 15:33:57 UTC
From IRC:

15:31 <rishi> Can we consider                                                   
      https://bugzilla.gnome.org/show_bug.cgi?id=733213 and                     
      https://bugzilla.gnome.org/show_bug.cgi?id=731391 closed ?
15:32 <aday> based on the minimal testing i've done here, i'd say yes