After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731250 - dvbsrc: tuning/locking logic improvements
dvbsrc: tuning/locking logic improvements
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.3.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-05 05:51 UTC by Reynaldo H. Verdejo Pinochet
Modified: 2014-06-06 10:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
improve timeout handing at tuning/locking loop (5.53 KB, patch)
2014-06-05 05:51 UTC, Reynaldo H. Verdejo Pinochet 		none Details | Review
drop redundant assignment (776 bytes, patch)
2014-06-05 05:52 UTC, Reynaldo H. Verdejo Pinochet 		none Details | Review
add Samsung copyright attribution (890 bytes, patch)
2014-06-05 05:53 UTC, Reynaldo H. Verdejo Pinochet 		none Details | Review
improve timeout handing at tuning/locking loop (5.95 KB, patch)
2014-06-05 06:07 UTC, Reynaldo H. Verdejo Pinochet 		committed Details | Review
drop redundant assignment (776 bytes, patch)
2014-06-05 06:10 UTC, Reynaldo H. Verdejo Pinochet 		committed Details | Review

Description Reynaldo H. Verdejo Pinochet 2014-06-05 05:51:50 UTC 
Created attachment 277923 [details] [review]
improve timeout handing at tuning/locking loop

* improve timeout handing at tuning/locking loop
* drop redundant assignment

Unrelated (but kinda due):

* add Samsung copyright attribution
Comment 1 Reynaldo H. Verdejo Pinochet 2014-06-05 05:52:29 UTC 
Created attachment 277924 [details] [review]
drop redundant assignment
Comment 2 Reynaldo H. Verdejo Pinochet 2014-06-05 05:53:20 UTC 
Created attachment 277925 [details] [review]
add Samsung copyright attribution
Comment 3 Reynaldo H. Verdejo Pinochet 2014-06-05 06:07:57 UTC 
Created attachment 277926 [details] [review]
improve timeout handing at tuning/locking loop

Squashing the copyright one over
Comment 4 Reynaldo H. Verdejo Pinochet 2014-06-05 06:10:46 UTC 
Created attachment 277927 [details] [review]
drop redundant assignment
Comment 5 Reynaldo H. Verdejo Pinochet 2014-06-05 17:04:17 UTC 
Pushed with a comment block on top of the ioctl_retry
(Edward approved privately).

commit 7c1f7fd78744b177070cd192541b272ff378111e
Author: Reynaldo H. Verdejo Pinochet <r.verdejo@sisa.samsung.com>
Date:   Wed Jun 4 14:35:51 2014 -0400

    dvbsrc: drop redundant assignment

commit 56933d97ecddd0ec27ca6e45cde17070f20a3d3b
Author: Reynaldo H. Verdejo Pinochet <r.verdejo@sisa.samsung.com>
Date:   Wed Jun 4 01:02:20 2014 -0400

    dvbsrc: improve timeout handing at locking loop
    
    New approach attempts to be more accurate by measuring
    the elapsed time by iteration. Also:
    
    * Use a 10 seconds default timeout and a half a second
      polling step. New values should better match the tuning
      process on real-life scenarios.
    * Correct elapsed_time computation.
    * Add _retry_ioctl() to avoid bailing out on temporary
      ioctl EINTR failures (no need to check for EAGAIN cause
      we are opening the frontend on blocking mode)
    * Small corrections to fail condition handling