GNOME Bugzilla – Bug 73078
nautilus needs to use new help API
Last modified: 2004-12-22 21:47:04 UTC
Nautilus needs to call the new help API when you click on the user manual in the help menu. It currently just fires off an error because it no longer has a help uri handler itself.
Regression, and big for usability.
Created attachment 7895 [details] [review] Proposed patch .
Added a directory C under help and copied nautius-user-manual.xml as nautilus.xml under this directory. Added the help API gnome_help_display to open the Help document when "Nautilus User Manual" is clicked.
Moving the users manual to help/C/ is not the right solution. Eugene O'Connor at Sun is working on a new GNOME Users Guide - help for Nautilus will be included as a chapter. So the help needs to link to something along the lines of "ghelp:gnome-users- guide?nautilus".
*** Bug 81081 has been marked as a duplicate of this bug. ***
Is the Sun doc going to be ready for 2.0.0? Or do we need a quick fix for this release? We could link up the old doc fairly easily I should think.
The Sun doc will be ready in time. Adding Sander to cc list - he's working on the doc installation.
from what Eugene said in his mail today, he will be doing the sgml -> xml process on tuesday and hand the doc over on wednesday, so yes, it will happen before 2.0
Jfleck, Sander: what is the status here? Dave: fairly easy one for you, probably.
well, in the meanwhile stuiff (ui review etc) happened so the handover of docs from eugene to me is still pending 8-( satyajit's patch - if it is not yet in - should go in ASAP as the user guiide docs won't live in separate module and can thus seemlessly plug in
Adding the PATCH keyword.
Redoing the earlier patch to link the help button to appropiate Help documents present under "user-guide". Shall put the patch soon.
Created attachment 8771 [details] [review] Updated patch to fetch the document from user-guide.
Couple of comments: * Don't include the all-including gnome.h, instead pick only the headerfiles you need. * Move the GtkWidget *dialog; declaration to the top of the function. Other than that, it looks fine to commit.
Thanks .. I 'll redo the patch for the #include stuff. But I think the next part GtkWidget *dialog should be inside if(error) { } only. As this part will only come in case of an error.
Where does this bug stand? I'll be very sad if we can't get this patch in.
The nautilus style guide says: "We declare local variables at the top of the function." I don't care if you don't think that is right.
I checked in the patch.
Reopening. This still isn't working right for me. The function calls Yelp, but displays the entire wgosnautilus.xml from its beginning rather than going to the correct section. Attaching a patch that fixes this.
Created attachment 8939 [details] [review] patch
Committed. Reclosing.