After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729951 - base: keep new GstSparseFile helper API private
base: keep new GstSparseFile helper API private
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal blocker
: 1.3.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-11 10:53 UTC by Tim-Philipp Müller
Modified: 2014-05-13 19:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Tim-Philipp Müller 2014-05-11 10:53:06 UTC 
Why is GstSparseFile public API in libgstbase instead of an internal implementation detail of the download buffer plugin?

Is it expected that other elements (that will not end up the core elements plugin) will soon make use of this abstraction as well? Or applications?

We should not expose new API unless there's a good reason to make it public IMHO. (Additionally, the API could use some review re. cross-platform aspects and binding-friendliness.)
Comment 1 Tim-Philipp Müller 2014-05-13 19:18:01 UTC 
commit fa94322349808e6c4fac1e48204fd5602f4e99e3
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Tue May 13 19:30:38 2014 +0100

    sparsefile: keep it private as helper API for downloadbuffer
    
    There's no expectation that any other element or applications
    might want to use this helper API any time soon, so keep it
    private for the time being. There were open questions regarding
    portability and binding-friendliness too.
    
    This also removes the gio dependency of -base again.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=729951
    https://bugzilla.gnome.org/show_bug.cgi?id=729949