After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729726 - Fix the accelerators for next/previous in RTL
Fix the accelerators for next/previous in RTL
Status: RESOLVED OBSOLETE
Product: epiphany
Classification: Core
Component: I18N
3.28.x
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-07 15:35 UTC by Yosef Or Boczko
Modified: 2018-08-03 20:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ephy-window: Fix the accelerators for back/forward in RTL (3.42 KB, patch)
2014-05-08 10:59 UTC, Yosef Or Boczko
none Details | Review
ephy-window: Fix the accelerators for back/forward in RTL (5.05 KB, patch)
2014-09-17 13:28 UTC, Yosef Or Boczko
needs-work Details | Review

Description Yosef Or Boczko 2014-05-07 15:35:49 UTC
Like the arrows.
Alt+Right for previous and Alt+Left for next.
Comment 1 Yosef Or Boczko 2014-05-08 10:59:23 UTC
Created attachment 276149 [details] [review]
ephy-window: Fix the accelerators for back/forward in RTL
Comment 2 Yosef Or Boczko 2014-08-10 08:56:18 UTC
Ping?
Comment 3 Yosef Or Boczko 2014-09-17 13:28:40 UTC
Created attachment 286373 [details] [review]
ephy-window: Fix the accelerators for back/forward in RTL
Comment 4 Michael Catanzaro 2014-12-11 10:41:01 UTC
Review of attachment 286373 [details] [review]:

Thanks for the patch, and sorry for the delay.

Can you rearrange the function to avoid the duplicate code when iterating over the keybindings object? I think should should only need to write that loop once.
Comment 5 Michael Catanzaro 2018-03-25 17:45:24 UTC
This is a mass NEEDINFO of all Epiphany bugs with no activity in the past three years. I'm going to be automatically closing old bugs to help us focus on current problems. If you feel this bug is still relevant with Epiphany 3.26 or newer, then please leave any comment here so that I know not to close this one.
Comment 6 Piotr Drąg 2018-03-25 22:37:57 UTC
I can reproduce on 3.28.
Comment 7 GNOME Infrastructure Team 2018-08-03 20:18:22 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/epiphany/issues/239.