After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 72959 - Making histograms from selection
Making histograms from selection
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
1.x
Other All
: Normal enhancement
: Future
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2002-02-28 10:34 UTC by Piotr Legiecki
Modified: 2004-12-10 23:11 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Piotr Legiecki 2002-02-28 10:34:44 UTC
I'd like to have the possibility of making histograms from part (selection)
of an image. Why can't I do this? Even when I make selection the histogram
is still based on entire image. Strange because histogram in Levels' window
is selection sensitive. 

For photos it would be usefull to select only main subject and analyse only
his own histogram.
Comment 1 Alan Horkan 2003-07-23 18:41:42 UTC
Changes at the request of Dave Neary on the developer mailing list.  
I am changing many of the bugzilla reports that have not specified a target
milestone to Future milestone.  Hope that is acceptable.  
Comment 2 Maurits Rijk 2003-07-24 17:12:02 UTC
This sound more like an enhancement than a bug. Therefore I'm changing
this to make the real bug-list more managable.
Comment 3 Maurits Rijk 2003-07-24 17:47:37 UTC
I could be mistaken, but this looks completely trivial to implement:
just add a gimp_drawable_mask_bounds to gimp_tool_histogram_initialize
in gimphistogramtool.c. Sven/Mitch: any reason for not doing this?
Comment 4 Sven Neumann 2003-07-24 21:30:21 UTC
gimp_drawable_mask_bounds would only restrict it to the bounding box
of the selection. That doesn't seem like the right thing to do. We'd
have to weight the pixel values by the respective values in the
selection mask. That would of course also not be difficult to implement.
Comment 5 Sven Neumann 2003-11-01 16:22:49 UTC
It seems to be a lot simpler actually: gimp_histogram_calculate()
takes a a mask parameter. We just need to use it. I'm just not sure
how the user interface should look like. IMO the GimpHistogramEditor
widget should be as compact as possible.
Comment 6 weskaggs 2004-09-05 14:21:34 UTC
I don't see why the user interface has to change at all.  If there is a
selection, use it, no questions asked.  This seems to be the way most things in
Gimp work.
Comment 7 weskaggs 2004-12-10 23:11:56 UTC
Following further discussion on mailing list, done as suggested: the histogram
widget now uses only the contents of the selection.  A rare case where
functionality can be added by making the code simpler!  

2004-12-09  Bill Skaggs <weskaggs@primate.ucdavis.edu>

	* app/widgets/gimphistogrameditor.c: make histogram editor,
	and therefore histogram dialog, use the selection.  Should
	resolve bug #72959.