After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728384 - Make DBus-activatable
Make DBus-activatable
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: devhelp-maint
devhelp-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-17 00:14 UTC by Matthias Clasen
Modified: 2015-05-24 08:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Convert to new-style commandline option handling (8.01 KB, patch)
2014-04-17 00:14 UTC, Matthias Clasen 		none Details | Review
Make DBus-activatable (3.17 KB, patch)
2014-04-17 00:15 UTC, Matthias Clasen 		none Details | Review
Implement GApplication::activate (1.47 KB, patch)
2015-05-23 16:59 UTC, Matthias Clasen 		none Details | Review

Description Matthias Clasen 2014-04-17 00:14:52 UTC 
Created attachment 274538 [details] [review]
Convert to new-style commandline option handling

These commits switch to new-style commandline option handling, install a
service file, rename the desktop file to follow the bus name, and add the
DBusActivatable key to the desktop file, following
https://wiki.gnome.org/HowDoI/DBusApplicationLaunching
Comment 1 Matthias Clasen 2014-04-17 00:15:38 UTC 
Created attachment 274539 [details] [review]
Make DBus-activatable
Comment 2 Frederic Peters 2014-04-19 11:57:37 UTC 
Starting devhelp from the shell overview correctly starts "devhelp --gapplication-service" but no window appear.

Running it from the command line diesplays a message about g_application_activate() or the 'activate' signal; is there anything missing?  (running Weather works fine, so I believe my environment is fine wrt dbus-activated apps).

 $ /scratch/jhbuild/bin/devhelp --gapplication-service
(devhelp:24813): GLib-GIO-WARNING **: Your application does not implement g_application_activate() and has no handlers connected to the 'activate' signal.  It should do one of these.
Comment 3 Matthias Clasen 2015-05-23 16:59:53 UTC 
Created attachment 303863 [details] [review]
Implement GApplication::activate

A GtkApplication is expected to present a window when
org.freedesktop.Application.Activate is called. This is
needed to make DBus activation work properly.
Comment 4 Matthias Clasen 2015-05-23 17:00:39 UTC 
Sorry that it took me a while to get back to this. The third patch has what was missing: an implementation of activate.
Comment 5 Frederic Peters 2015-05-24 08:38:43 UTC 
Thank you Matthias.

Attachment 274538 [details] pushed as 1de0fb9 - Convert to new-style commandline option handling
Attachment 303863 [details] pushed as cd718f9 - Implement GApplication::activate