After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728302 - Make DBus-activatable
Make DBus-activatable
Status: RESOLVED FIXED
Product: gnome-dictionary
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-dictionary-maint
gnome-dictionary-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-15 23:09 UTC by Matthias Clasen
Modified: 2014-11-21 16:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Convert to new-style commandline option handling (5.94 KB, patch)
2014-04-15 23:09 UTC, Matthias Clasen 		committed Details | Review
Make DBus-activatable (3.39 KB, patch)
2014-04-15 23:10 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2014-04-15 23:09:33 UTC 
Created attachment 274405 [details] [review]
Convert to new-style commandline option handling

These commits switch to new-style commandline option handling, install a
service file, rename the desktop file to follow the bus name, and add the
DBusActivatable key to the desktop file, following
https://wiki.gnome.org/HowDoI/DBusApplicationLaunching
Comment 1 Matthias Clasen 2014-04-15 23:10:04 UTC 
Created attachment 274406 [details] [review]
Make DBus-activatable
Comment 2 Emmanuele Bassi (:ebassi) 2014-04-15 23:15:17 UTC 
Review of attachment 274405 [details] [review]:

::: src/gdict-app.c
@@ +194,3 @@
 
+gchar **
+strv_concat (gchar **strv1, gchar **strv2)

side note: `strv_concat()` would be useful in GLib.

@@ +211,3 @@
+
+static void
+  len2 = g_strv_length (strv2);

I guess `print_strv()` is there for debugging, but it should probably either be ifdef'ed out, or removed.
Comment 3 Emmanuele Bassi (:ebassi) 2014-04-15 23:16:05 UTC 
Review of attachment 274406 [details] [review]:

looks good. thanks for doing the work.
Comment 4 Matthias Clasen 2014-04-15 23:18:29 UTC 
(In reply to comment #2)
;
> 
> I guess `print_strv()` is there for debugging, but it should probably either be
> ifdef'ed out, or removed.

Urgh, obviously a leftover. I'll take it out
Comment 5 Matthias Clasen 2014-11-21 16:56:58 UTC 
Attachment 274405 [details] pushed as 7bf2dc4 - Convert to new-style commandline option handling
Attachment 274406 [details] pushed as bf83d76 - Make DBus-activatable