GNOME Bugzilla – Bug 725648
Switches should always indicate the current state
Last modified: 2014-04-06 05:53:50 UTC
Created attachment 270888 [details] rough mockup Currently, switches show the state that the widget is in: they are either in an on or an off position. However, sometimes the thing that the switch controls might be in a different state from the widget. This is most common when a switch controls a piece of hardware: you might switch off bluetooth, but it might take a few seconds to power off. In that time, the switch indicates that bluetooth is off, even when it is still on. This might seem like a minor thing, but it would be an enhancement to the widget, in that it would reinforce the direct and transparent relationship between the control and its target. One thing we'd have to resolve is how switches would look in the various possible states. I've attached a really bad mockup which should hopefully communicate the idea.
Pushed a switch-state branch that implements this
Created attachment 273244 [details] screencast sorry for the big video - I donated to pitivi, but sadly, it can't even crop a video :-( The video shows a switch where the change of the underlying state is delayed by 2 seconds. I've added a spinner to indicate when the ui state and the underlying state are different. The checkbox represents the underlying state
https://git.gnome.org/browse/gtk+/log/?h=switch-state
Looks fantastic! Could be nice to use a CSS transition for the color change of the background, but that's a detail we can look at later.
quick things I noticed skimming the branch: * the ::set-state signal should really be ::state-set instead * need to remove a padding slot in the SwitchClass structure * maybe have symbolic constants for the ::state-set return value, like we do for GSource and event handling - something lik GTK_SWITCH_APPLY_STATE and GTK_SWITCH_DELAY_STATE - just to improve readability
(In reply to comment #5) > * maybe have symbolic constants for the ::state-set return value, like we do > for GSource and event handling - something lik GTK_SWITCH_APPLY_STATE and > GTK_SWITCH_DELAY_STATE - just to improve readability I think that would rather be G_SIGNAL_CONTINUE / G_SIGNAL_STOP and be used for all signals using TRUE-to-stop semantics