After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725463 - change bandwidth to DVBv5-API
change bandwidth to DVBv5-API
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-01 20:28 UTC by Stefan Ringel
Modified: 2014-03-15 13:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
change bandwidth to DVBv5-API (7.28 KB, patch)
2014-03-01 20:28 UTC, Stefan Ringel
none Details | Review
add compatabily (6.13 KB, patch)
2014-03-02 15:12 UTC, Stefan Ringel
none Details | Review
add bandwidth-hz property (9.83 KB, patch)
2014-03-04 12:21 UTC, Stefan Ringel
none Details | Review

Description Stefan Ringel 2014-03-01 20:28:01 UTC
Created attachment 270644 [details] [review]
change bandwidth to DVBv5-API

DVBv5-API use not an enum for bandwidth value, but the real frequency.
Comment 1 Edward Hervey 2014-03-02 10:11:51 UTC
While I agree on the intent of the patch, I'm worried this might be considered an API break (the property is no longer an enum but an integer).

Maybe we should create a new property and mark the old one as deprecated. This should keep backwards compatibility.
Comment 2 Stefan Ringel 2014-03-02 10:23:52 UTC
How I can marked the old property as deprecated?
Comment 3 Sebastian Dröge (slomo) 2014-03-02 11:02:37 UTC
The dvb plugin is in gst-plugins-bad, so if it makes sense to remove properties I think we should consider doing that instead of cluttering the interface of the elements with lots of deprecated no-op properties.
Comment 4 Stefan Ringel 2014-03-02 15:12:07 UTC
Created attachment 270701 [details] [review]
add compatabily
Comment 5 Stefan Ringel 2014-03-03 16:17:18 UTC
(In reply to comment #1)
> While I agree on the intent of the patch, I'm worried this might be considered
> an API break (the property is no longer an enum but an integer).
> 
> Maybe we should create a new property and mark the old one as deprecated. This
> should keep backwards compatibility.

Edward, which name should have the new property? Or is it better to rename the old with a prefix (_dvbv3)? Not that we rename the new property in the future to the old name. How many apps use GStreamer 1.x with dvbsrc/dvbbasebin plugin? I thing no apps, but apps which use GSteamer 0.10 I have see many of it.
Comment 6 Stefan Ringel 2014-03-03 16:32:56 UTC
P.S. Bandwidth going to more flexibily. Today we have 1.172, 5, 6, 7, 8, 10 MHz.
Comment 7 Stefan Ringel 2014-03-04 12:21:31 UTC
Created attachment 270897 [details] [review]
add bandwidth-hz property
Comment 8 Edward Hervey 2014-03-15 13:27:06 UTC
commit fd8bda1c0384c84fc33922aef1559800d8400e2a
Author: Stefan Ringel <linuxtv@stefanringel.de>
Date:   Tue Mar 4 13:19:55 2014 +0100

    dvbsrc: mpegts: change bandwidth to DVBv5 values
    
    Signed-off-by: Stefan Ringel <linuxtv@stefanringel.de>
    
    https://bugzilla.gnome.org/show_bug.cgi?id=725463