After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724699 - katedec: Katedec overwrites tags from oggdemux
katedec: Katedec overwrites tags from oggdemux
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-18 23:27 UTC by Brendan Long
Modified: 2014-02-23 09:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Example Ogg file with two kate streams (151.02 KB, video/ogg)
2014-02-18 23:27 UTC, Brendan Long
  Details
Patch to merge new tags in katedec (8.91 KB, patch)
2014-02-19 01:18 UTC, Brendan Long
none Details | Review
Patch to merge new tags in katedec (9.04 KB, patch)
2014-02-19 01:23 UTC, Brendan Long
committed Details | Review

Description Brendan Long 2014-02-18 23:27:20 UTC
Created attachment 269636 [details]
Example Ogg file with two kate streams

oggdemux always sends a tag with just: container-format=(string)Ogg

That tag never shows up for me after katedec though, but if I remove the tag sending in gstkateutil it shows up. My assumption is that the sticky event handling code is throwing away the original tag and replacing it with the new kate tag.

This is especially annoying because I'm trying to add more interesting tags from Ogg Skeleton, and they work fine for Theora but not for Kate:

https://bugzilla.gnome.org/show_bug.cgi?id=698853
Comment 1 Brendan Long 2014-02-19 01:18:03 UTC
Created attachment 269645 [details] [review]
Patch to merge new tags in katedec

The helper functions may be overkill here, but there are several places where we create tags.
Comment 2 Brendan Long 2014-02-19 01:23:35 UTC
Created attachment 269646 [details] [review]
Patch to merge new tags in katedec

This makes the helper functions slightly smarter.
Comment 3 Sebastian Dröge (slomo) 2014-02-23 09:52:48 UTC
commit 7f591f9c7e3e2e8304b74a2086b7d91509514dff
Author: Brendan Long <self@brendanlong.com>
Date:   Tue Feb 18 19:16:35 2014 -0600

    katedec: Merge new tags with existing tags to prevent overwriting demuxer tags
    
    https://bugzilla.gnome.org/show_bug.cgi?id=724699