After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724471 - Use header bar in the interactive dialog
Use header bar in the interactive dialog
Status: RESOLVED FIXED
Product: gnome-screenshot
Classification: Core
Component: general
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-screenshot-maint
gnome-screenshot-maint
: 711221 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-02-16 11:02 UTC by Yosef Or Boczko
Modified: 2014-04-13 10:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot: Use header bar in the interactive dialog (3.18 KB, patch)
2014-02-16 11:03 UTC, Yosef Or Boczko
committed Details | Review
screenshot-dialog: Remove the cancel button and add X button instead (2.44 KB, patch)
2014-02-16 17:47 UTC, Yosef Or Boczko
committed Details | Review

Description Yosef Or Boczko 2014-02-16 11:02:03 UTC
See the patch.
Comment 1 Yosef Or Boczko 2014-02-16 11:03:14 UTC
Created attachment 269289 [details] [review]
screenshot: Use header bar in the interactive dialog
Comment 2 Cosimo Cecchi 2014-02-16 16:41:10 UTC
Attachment 269289 [details] pushed as a6d21b7 - screenshot: Use header bar in the interactive dialog

Thanks, I pushed this one with a bunch of additional tweaks on top.
Comment 4 Cosimo Cecchi 2014-02-16 17:12:56 UTC
OK I fixed the size group part. The other commit is right - see https://git.gnome.org/browse/gtk+/tree/gtk/gtkbutton.c#n1278
Comment 5 Yosef Or Boczko 2014-02-16 17:15:47 UTC
In the save dialog, I think we wants to remove the Cancel button,
and to add instead the X button, with the show-close-button property
of GtkHeaderBar.
Comment 6 Cosimo Cecchi 2014-02-16 17:44:32 UTC
(In reply to comment #5)
> In the save dialog, I think we wants to remove the Cancel button,
> and to add instead the X button, with the show-close-button property
> of GtkHeaderBar.

Sounds good - want to make a patch? :-)
Comment 7 Yosef Or Boczko 2014-02-16 17:45:09 UTC
OK, one second.
Comment 8 Yosef Or Boczko 2014-02-16 17:47:57 UTC
Created attachment 269318 [details] [review]
screenshot-dialog: Remove the cancel button and add X button instead
Comment 9 Yosef Or Boczko 2014-02-16 18:43:10 UTC
Review of attachment 269318 [details] [review]:

Pushed as d8fcafe - screenshot-dialog: Remove the cancel button and add X button instead
Comment 10 Yosef Or Boczko 2014-04-13 10:59:14 UTC
*** Bug 711221 has been marked as a duplicate of this bug. ***