After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723849 - matroska: add support for GRAY8, BGR and RGB video colourspaces in V_UNCOMPRESSED codec
matroska: add support for GRAY8, BGR and RGB video colourspaces in V_UNCOMPR...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-07 13:16 UTC by Dirk Van Haerenborgh
Modified: 2014-02-11 20:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (2.49 KB, patch)
2014-02-07 13:16 UTC, Dirk Van Haerenborgh 		committed Details | Review

Description Dirk Van Haerenborgh 2014-02-07 13:16:12 UTC 
Created attachment 268404 [details] [review]
Proposed patch

Following the matroska specification, there is support for raw frames by using the V_UNCOMPRESSED codec. 
The patch attached adds support for GRAY8, BGR and RGB colourspaces.

According to the specification (http://matroska.org/technical/specs/index.html), all details about the used colour space are to be put in the header's ColourSpace field, and it should have the same value as in AVI.

For GRAY8 data, this is trivial, but for BGR/RGB less so, as the fourcc value for BGR/RGB is 0. Therefore, the fourcc codes used in this patch originate from what is used in MPlayer (http://orion.lcg.ufrj.br/RPMS/src/mplayer/mplayer/vidix/fourcc.h)

There is currently no other player that supports raw GRAY8/BGR/RGB data in matroska, though it is perfectly 'legal' according to the spec. Still, the timestamp information with every frame is a big advantage in using matroska over avi.
Comment 1 Sebastian Dröge (slomo) 2014-02-11 20:23:21 UTC 
commit 19a307930a9e44b5453501ec3ae8b6890ed489c0
Author: divhaere <dirk.vanhaerenborgh@ugent.be>
Date:   Fri Feb 7 14:00:15 2014 +0100

    matroska: add support for GRAY8, BGR and RGB video colourspaces in V_UNCOMPRESSED codec
    
    https://bugzilla.gnome.org/show_bug.cgi?id=723849