GNOME Bugzilla – Bug 722981
autodetect elements have inconsistent handling of autoplugin
Last modified: 2014-02-23 19:41:41 UTC
The gst_auto_*_find_best() methods are a little inconsistent with regards to error handling. If we have candidate elements and they don't work, we post a message and leave the bin empty. If we have no candidates, we plug a fakesink/src. I guess posting a missing-elements message if we have no candidates makes little sense. two ideas: a) If we have candidates, but none of them works, we post only a warning and plug fakesink/src as well. But that sounds like hiding the issue. b) If we have no candidates we also post an error.
I think that both sounds good
Created attachment 270009 [details] [review] autodetect: demote candidate error to warning and plug fake{sink,src} In the case where we have no suitable candidate we post a warning and plug a fake-element. Do the same when non of the candidate work. This is more consistent and plugin the fakesink as a fallback is probably helpful for running unit tests without requiring hardware src/sink elements. Fixes #722981
Review of attachment 270009 [details] [review]: Sounds good to me
The following fix has been pushed: fdb5d46 autodetect: demote candidate error to warning and plug fake{sink,src}
Created attachment 270061 [details] [review] autodetect: demote candidate error to warning and plug fake{sink,src} In the case where we have no suitable candidate we post a warning and plug a fake-element. Do the same when non of the candidate work. This is more consistent and plugin the fakesink as a fallback is probably helpful for running unit tests without requiring hardware src/sink elements. Fixes #722981