Created attachment 6821 [details] [review]
Patch implementing the enter-click focus mode

Thanks. That looks interesting.

But I'm not sure this is the most logical way to do this. I can see
two alternatives:

1. it's a bug that the pointer can ever be over a non-focused window
in enter-{only,click} modes

2. accept that (1) will happen and make the existing enter- modes
support clicking in unfocused windows to focus them

what do you think?

John, I assume you meant "enter-{only,exit}", not
"enter-{only,click}", since enter-click was my implementation of (2)
for the enter-only mode.

Fixing (1) would involve changing warp-to-selected-windows to
warp-to-focused-windows (which does make more sense, especially in the
enter-* modes, IMHO).

I see two ways of doing (2):

a: Substitute my enter-click mode for the existing enter-only mode,
and augment enter-exit with the same functionality (this behaviour
should be controlled by a preference setting).

b: Implement a command focus-and-pass-through-click and bind it to
Button1-click in window context.

I think (a) is the cleanest way of doing it.

Created attachment 111489 [details] [review]
updated patch for v1.3.3

Just a small update to apply against v1.3.3

A modified version has been comitted.