After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721655 - basesrc activation order logs error in some cases where it should not
basesrc activation order logs error in some cases where it should not
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
1.x
Other Linux
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-06 20:56 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2017-07-14 13:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
don't confuse GST_PAD_MODE_NONE and PULL (3.23 KB, patch)
2014-01-06 20:57 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2014-01-06 20:56:55 UTC 
gst-launch-1.0 fakesrc can-activate-pull=false num-buffers=0 ! fakesink can-activate-pull=true

This is a followup for the discussion after I submitted
commit 74adc33982e08dd3bf1c1a991f8519dd821df549
Author: Stefan Sauer <ensonic@users.sf.net>
Date:   Mon Jan 6 21:04:32 2014 +0100

basesrc: demote error to warning
    
This is not an error. A subclass returning FALSE for is_seekable() is one way of
saying that we can't operate in pull mode.


Here is a better patch. Main question is wheter we should end up calling start() before the pad is activated(). Previously I tried to make gst_base_src_activate_pull() fail if !gst_base_src_seekable(), but that code is not yet called at that moment.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2014-01-06 20:57:45 UTC 
Created attachment 265476 [details] [review]
don't confuse GST_PAD_MODE_NONE and PULL
Comment 2 Sebastian Dröge (slomo) 2014-01-07 08:06:36 UTC 
Comment on attachment 265476 [details] [review]
don't confuse GST_PAD_MODE_NONE and PULL

I think this looks good and makes sense
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2014-01-09 07:52:39 UTC 
wtay, any comments?
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2014-01-09 14:35:02 UTC 
I intentionally left this open, as I am not sure if we should even get there with unactivated pads in the first place ...
Comment 5 Sebastian Dröge (slomo) 2014-01-09 15:18:33 UTC 
Then let's reopen it :)

How do we get there with unactivated pads?
Comment 6 Tim-Philipp Müller 2017-07-14 13:57:53 UTC 
Let's close this again, I think it's not worth keeping this open :)