After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720371 - rtpbin: Impossible to set jitterbuffer rtx-* properties when using rtpbin
rtpbin: Impossible to set jitterbuffer rtx-* properties when using rtpbin
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-13 02:41 UTC by Olivier Crête
Modified: 2013-12-30 15:54 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Olivier Crête 2013-12-13 02:41:24 UTC
It's currently not possible to set the rtx-* properties of a jitterbuffer when it's used inside rtpbin. This is trickier than the "latency" as these could be different for each session I believe.

Maybe we need an API to g_signal_emit_by_name(rtpbin, "set-jitterbuffer-property", guint session_id, char * property_name, gint value) with the associated g_signal_emit_by_name(rtpbin, "get-jitterbuffer-property", guint session_id, gchar * property_name, gint *value);

We could also replace the gint by a GValue, but then it gets uglier to use because of GValue.
Comment 1 Sebastian Dröge (slomo) 2013-12-14 17:37:11 UTC
Or API to get the session instances? Or set-rtx-* (session_id, value)?
Comment 2 Olivier Crête 2013-12-14 22:41:35 UTC
The problem with that approach is that the jitterbuffer is not in the session object and there are multiple jitterbuffer instances per session, one per received ssrc.
Comment 3 Wim Taymans 2013-12-27 16:04:42 UTC
How about a signal when a new jitterbuffer is made so that you can configure it? It's a bit tedious to keep on proxying those properties and it doesn't solve the issue when you want different values per jitterbuffer.
Comment 4 Wim Taymans 2013-12-30 15:54:13 UTC
commit 5a2bc1405eff43493682721ceb8cb8bf94806242
Author: Wim Taymans <wtaymans@redhat.com>
Date:   Mon Dec 30 16:52:28 2013 +0100

    rtpbin: add signal for new jitterbuffer
    
    Emit a signal when a new jitterbuffer is created so that the app can
    have a chance to configure it.